phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Undesirable workaround for Audio preferences. #215

Closed pixelzoom closed 5 months ago

pixelzoom commented 5 months ago

For code review #32 ...

In projectile-data-lab-main.ts, a blank Node is being created for the left column of the Audio preferences tab, to workaround a joist layout problem -- see relevant code below. Rather than creating an undesirable dependency on bad layout behavior, it would be preferrable to fix the layout problem in joist. Or at least open a GitHub issue for the problem, with a TODO here, so that the problem may eventually get fixed, and someone will know to remove this workaround.

    audioOptions: {
      customPreferences: [
        {

          // Due to the layout considerations in the Preferences Dialog, it has 2 columns. Our entry for the left column
          // is blank
          createContent: () => new Node()
        },
        {
        createContent: tandem => new AudioPreferencesContentNode( tandem.createTandem( 'audioPreferences' ) )
      } ]
samreid commented 5 months ago

This was discussed a bit yesterday, but I don't recall the conclusion.

pixelzoom commented 5 months ago

The conclusion was:

samreid commented 5 months ago

I opened the Joist issue and pointed TODOs at it. Closing.