Closed pixelzoom closed 5 months ago
This was discussed a bit yesterday, but I don't recall the conclusion.
The conclusion was:
audioOptions.customPreferences
API, so that this type of workaround is not needed.I opened the Joist issue and pointed TODOs at it. Closing.
For code review #32 ...
In projectile-data-lab-main.ts, a blank Node is being created for the left column of the Audio preferences tab, to workaround a joist layout problem -- see relevant code below. Rather than creating an undesirable dependency on bad layout behavior, it would be preferrable to fix the layout problem in joist. Or at least open a GitHub issue for the problem, with a TODO here, so that the problem may eventually get fixed, and someone will know to remove this workaround.