Closed pixelzoom closed 5 months ago
In https://github.com/phetsims/projectile-data-lab/commit/4a4af06cd50ee169929f9d3f5a5375dadd786a45, I addressed all of the cases expect for MeasuresScreenView.ts and SourcesScreenView.ts, in case you want to apply the patch provided in https://github.com/phetsims/projectile-data-lab/issues/217.
For FieldOverlayNode, I made the isLeftSide
option required, because I think it makes the call site in PDLScreenView clearer:
const fieldOverlayBack = new FieldOverlayNode( this.modelViewTransform, { isLeftSide: false } );
const fieldOverlayFront = new FieldOverlayNode( this.modelViewTransform, { isLeftSide: true } );
In https://github.com/phetsims/projectile-data-lab/commit/b99f117c93675a1030bd38b2a550d16778580ea0, I fixed an incorrect options pattern for CustomLauncherNodeOptions, and made providedOptions
optional. So you should be able to simply remove the {}
from MeasuresScreenView.ts and SourcesScreenView.ts.
Over to @samreid or @matthew-blackman to review and complete work.
I removed the remaining instances of empty providedOptions. Thanks for the review feedback and fix @pixelzoom! Closing.
For code review #32 ...
There are quite a few places where an unnecessary
{}
is provides as the argument forprovidedOptions
, which is either optional or should be optional.