search

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

VSMField resets field owned by superclass Field. #221

Closed pixelzoom closed 5 months ago

pixelzoom commented 5 months ago

For code review #32 ...

VSMField is currently resetting angleStabilizerProperty, which is owned by superclass Field:

  public override reset(): void {
    super.reset();

    this.angleStabilizerProperty.reset();
    this.continuousLaunchTimer.reset();
  }

Why is angleStabilizerProperty not being reset in Field reset? If there a good reason, document. Otherwise move it.

samreid commented 5 months ago

Good recommendation. @matthew-blackman and I moved it to the parent class and it seems better. Closing.