Are sounds added to the correct categoryName?

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

0 stars 0 forks source link

Are sounds added to the correct categoryName? #228

Closed pixelzoom closed 5 months ago

pixelzoom commented 5 months ago

For code review #32 ...

There are 30 calls to soundManager.addSoundGenerator. 11 of those specify categoryName: 'user-interface', while the other 19 do not specify categoryName. Is that correct?

It might be worth adding something about categoryName to implementation-notes.md.

matthew-blackman commented 5 months ago

Sound category names have been updated. @samreid and I did not feel that the Interval Tool was not part of the 'user-interface' category, since it is on the field as opposed to being in the UI layer.

We did not feel that further documentation was needed in this sim, since the categoryName is used in tambo and has no sim-specific implementation. Closing.