Closed pixelzoom closed 5 months ago
For code review #32 ....
Duplicated twice in VSMScreenView.ts:
new DerivedProperty( [ model.totalProjectileCountProperty ], totalProjectileCount => { return totalProjectileCount < PDLQueryParameters.maxProjectilesVSMField; } )
Suggested change:
- launchButtonEnabledProperty: new DerivedProperty( [ model.totalProjectileCountProperty ], totalProjectileCount => { - return totalProjectileCount < PDLQueryParameters.maxProjectilesVSMField; - } ) + launchButtonEnabledProperty: launchButtonEnabledProperty
Fixed in the commit. Thanks for the review @pixelzoom. Closing.
For code review #32 ....
Duplicated twice in VSMScreenView.ts:
Suggested change: