search

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Angle stabilizer slider not updating with keyboard input #235

Closed matthew-blackman closed 5 months ago

matthew-blackman commented 5 months ago

@samreid mentioned that this could be caused by the keyboard increment being less than the snap increment for the slider. Let's investigate and fix.

matthew-blackman commented 5 months ago

@catherinecarter this is ready for review. As suspected, it was being caused by the snapping. I set the keyboard increment to align with the tick marks on the slider, with the Shift modifier allowing half-tick increments. I think it's working well and it seemed like a good idea to give Shift key more fine-tuned control, even within the snapping behavior. Feel free to close if all passes review.

catherinecarter commented 5 months ago

The left/right arrows are working well, the WASD keys are not working.

Also, I agree the Shift+arrows is nice to go in smaller increments. The end/home is also working nicely.

The page up/down is confusing. Usually the page up/down steps in larger steps than the left/right arrows(like the interval tool), but in this case, it's acting like the shift key and instead is moving in smaller steps.

I recommend having the page up/down go between two tick marks (end, middle, end), and leave the current left/right and shift+arrow as is.

The page up/down behavior will also need to be added to the keyboard help dialog box.

samreid commented 5 months ago

The left/right arrows are working well, the WASD keys are not working.

Thanks, I moved that to a sun-specific issue. Next I will work on the page up/down issues.

samreid commented 5 months ago

For the angle stabilizer slider, I fixed the pgup/pgdwn and added this help section:

image

We will adjust the layout in https://github.com/phetsims/projectile-data-lab/issues/239. Closing.