matthew-blackman
commented
5 months ago @samreid and I worked on this and ran into the following design issue:
- If a projectile is selected that was launched at 60 degrees, but the launcher is currently in the raised configuration, what should be displayed by the angle tool?
I don't see a way to get the heat map tools to also serve as a history tool. The speed and angle tools were designed to display data as they are collecting it, similar to a 'radar gun' as it is registering speed data. It was not designed to be a way to navigate prior data, but rather a live stream of data with a qualitative snapshot of the spread (the heat map itself).
In light of this design limitation, I think this issue can be closed. If we decide to redesign the speed/angle tools, then this may be possible in the future.
If we decide to pick this up at a later date, here is the patch from the work that @samreid and I started on this before running into design limitations:
``` diff
Subject: [PATCH] Add sampleNumber to CODAP available data - https://github.com/phetsims/projectile-data-lab/issues/243
---
Index: js/common-vsm/view/AngleToolNode.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/common-vsm/view/AngleToolNode.ts b/js/common-vsm/view/AngleToolNode.ts
--- a/js/common-vsm/view/AngleToolNode.ts (revision 5d5e2fc70076af92ace1f580069befbf6f987f74)
+++ b/js/common-vsm/view/AngleToolNode.ts (date 1710268940684)
@@ -55,7 +55,7 @@
// elementsForRaised is used to keep track of the elements that are visible when the tool is raised.
private readonly elementsForRaised: Node[] = [];
- public constructor( latestValueProperty: TReadOnlyProperty,
+ public constructor( displayedValueProperty: TReadOnlyProperty,
isRaisedProperty: TReadOnlyProperty,
providedOptions: AngleToolNodeOptions ) {
@@ -123,7 +123,7 @@
readoutPatternStringProperty: ProjectileDataLabStrings.valueDegreesPatternStringProperty,
isIcon: false
}, providedOptions );
- super( latestValueProperty, options );
+ super( displayedValueProperty, options );
// rotatedElements is used to keep track of the elements that need to be rotated to their correct positions.
const rotatedElements = [ ...this.heatNodes, ...this.tickMarks ];
Index: js/common-vsm/view/HeatMapToolNode.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/common-vsm/view/HeatMapToolNode.ts b/js/common-vsm/view/HeatMapToolNode.ts
--- a/js/common-vsm/view/HeatMapToolNode.ts (revision 5d5e2fc70076af92ace1f580069befbf6f987f74)
+++ b/js/common-vsm/view/HeatMapToolNode.ts (date 1710268868112)
@@ -153,8 +153,8 @@
// maxAngle is the maximum angle used to set the angular positioning of the heat nodes, in degrees.
private readonly maxAngle: number;
- // The latest value Property is used to update the heat map tool's needle rotation.
- public constructor( latestValueProperty: TReadOnlyProperty, providedOptions: HeatMapToolNodeOptions ) {
+ // The latest value Property is used to add data to the heat map, update the heat map tool's needle rotation and set the displayed value.
+ public constructor( displayedValueProperty: TReadOnlyProperty, providedOptions: HeatMapToolNodeOptions ) {
const options = optionize()( {
isWithMinorTickMarks: false,
@@ -211,8 +211,8 @@
this.needleNode = this.createNeedleNode( options.needleShape );
- const formattedValueProperty = new DerivedProperty( [ latestValueProperty ], latestValue => {
- return Utils.toFixed( latestValue, 1 );
+ const formattedValueProperty = new DerivedProperty( [ displayedValueProperty ], displayedValue => {
+ return Utils.toFixed( displayedValue, 1 );
} );
const valueUnitsPatternStringProperty = new PatternStringProperty( options.readoutPatternStringProperty, {
@@ -263,9 +263,9 @@
this.minAngle = options.minAngle;
this.maxAngle = options.maxAngle;
- // Update the needle rotation when the latest value changes
- latestValueProperty.link( latestValue => {
- this.setNeedleRotation( latestValue );
+ // Update the needle rotation when the displayed value changes
+ displayedValueProperty.link( displayedValue => {
+ this.setNeedleRotation( displayedValue );
} );
}
Index: js/common-vsm/view/VSMScreenView.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/common-vsm/view/VSMScreenView.ts b/js/common-vsm/view/VSMScreenView.ts
--- a/js/common-vsm/view/VSMScreenView.ts (revision 5d5e2fc70076af92ace1f580069befbf6f987f74)
+++ b/js/common-vsm/view/VSMScreenView.ts (date 1710269046960)
@@ -166,14 +166,14 @@
// Create the heat map tools
const speedToolNode = new SpeedToolNode(
- model.latestLaunchSpeedProperty,
+ model.displayedLaunchSpeedProperty,
isLauncherRaisedProperty, {
visibleProperty: model.isLaunchSpeedVisibleProperty,
x: originPosition.x, y: originPosition.y
} );
const angleToolNode = new AngleToolNode(
- model.latestLaunchAngleProperty,
+ model.displayedLaunchAngleProperty,
isLauncherRaisedProperty, {
visibleProperty: model.isLaunchAngleVisibleProperty,
x: originPosition.x, y: originPosition.y
Index: js/common-vsm/view/SpeedToolNode.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/common-vsm/view/SpeedToolNode.ts b/js/common-vsm/view/SpeedToolNode.ts
--- a/js/common-vsm/view/SpeedToolNode.ts (revision 5d5e2fc70076af92ace1f580069befbf6f987f74)
+++ b/js/common-vsm/view/SpeedToolNode.ts (date 1710268953188)
@@ -63,7 +63,7 @@
// The display offset is the position of the tool display panel relative to its origin.
private displayOffset: Vector2;
- public constructor( latestValueProperty: TReadOnlyProperty, isLauncherRaised: TReadOnlyProperty, providedOptions: SpeedToolNodeOptions ) {
+ public constructor( displayedValueProperty: TReadOnlyProperty, isLauncherRaised: TReadOnlyProperty, providedOptions: SpeedToolNodeOptions ) {
// The body shape is an arc that represents the background of the heat map display.
const bodyShape = new Shape().arc( 0, 0, BODY_RADIUS,
@@ -112,7 +112,7 @@
isClockwise: true,
isIcon: false
}, providedOptions );
- super( latestValueProperty, options );
+ super( displayedValueProperty, options );
this.displayOffset = options.displayOffset;
Index: js/common-vsm/model/VSMModel.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/common-vsm/model/VSMModel.ts b/js/common-vsm/model/VSMModel.ts
--- a/js/common-vsm/model/VSMModel.ts (revision 5d5e2fc70076af92ace1f580069befbf6f987f74)
+++ b/js/common-vsm/model/VSMModel.ts (date 1710268402387)
@@ -59,6 +59,9 @@
////////////////////////////////////////////////////////////////////////////////////////
// These DynamicProperties select based on the selected VSMField
+ public readonly displayedLaunchAngleProperty: TReadOnlyProperty;
+ public readonly displayedLaunchSpeedProperty: TReadOnlyProperty;
+
public readonly latestLaunchAngleProperty: TReadOnlyProperty;
public readonly latestLaunchSpeedProperty: TReadOnlyProperty;
@@ -111,6 +114,16 @@
validValues: allLaunchers
} );
+ this.displayedLaunchAngleProperty = new DynamicProperty( this.fieldProperty, {
+ bidirectional: true,
+ derive: field => field.displayedLaunchAngleProperty
+ } );
+
+ this.displayedLaunchSpeedProperty = new DynamicProperty( this.fieldProperty, {
+ bidirectional: true,
+ derive: field => field.displayedLaunchSpeedProperty
+ } );
+
this.latestLaunchAngleProperty = new DynamicProperty( this.fieldProperty, {
bidirectional: true,
derive: field => field.latestLaunchAngleProperty
Index: js/common-vsm/model/VSMField.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/common-vsm/model/VSMField.ts b/js/common-vsm/model/VSMField.ts
--- a/js/common-vsm/model/VSMField.ts (revision 5d5e2fc70076af92ace1f580069befbf6f987f74)
+++ b/js/common-vsm/model/VSMField.ts (date 1710269180848)
@@ -39,6 +39,12 @@
export default class VSMField extends Field {
+ // The launch angle being displayed on the angle heat map tool.
+ public readonly displayedLaunchAngleProperty: Property;
+
+ // The launch speed being displayed on the speed heat map tool.
+ public readonly displayedLaunchSpeedProperty: Property;
+
// The most recent launch angle on this field, in degrees
public readonly latestLaunchAngleProperty: Property;
@@ -80,21 +86,26 @@
super( launchers, launcherProperty, PDLUtils.colorForFieldIndex( VSMFieldIdentifierValues.indexOf( identifier ) ), options );
this.continuousLaunchTimer = new PDLEventTimer( PDLConstants.MINIMUM_TIME_BETWEEN_LAUNCHES, options.tandem.createTandem( 'continuousLaunchTimer' ) );
- this.latestLaunchAngleProperty = new NumberProperty( this.meanAngleProperty.value, {
- tandem: providedOptions.tandem.createTandem( 'latestLaunchAngleProperty' ),
+ this.displayedLaunchAngleProperty = new NumberProperty( this.meanAngleProperty.value, {
+ tandem: providedOptions.tandem.createTandem( 'displayedLaunchAngleProperty' ),
phetioReadOnly: true,
- phetioDocumentation: 'This Property is the current angle of the launcher, in degrees. When a projectile is launched, this property is set to the launch angle.'
- + ' When the launcher configuration or angle stabilizer changes, this Property is set to the configured launch angle.',
+ phetioDocumentation: 'This Property is the value displayed on the angle tool, in degrees.' +
+ 'When a projectile is launched or selected, this is set to the launch angle of that projectile.',
phetioFeatured: true
} );
- this.latestLaunchSpeedProperty = new NumberProperty( 0, {
- tandem: providedOptions.tandem.createTandem( 'latestLaunchSpeedProperty' ),
+ this.displayedLaunchSpeedProperty = new NumberProperty( 0, {
+ tandem: providedOptions.tandem.createTandem( 'displayedLaunchSpeedProperty' ),
phetioReadOnly: true,
- phetioDocumentation: 'This Property is the latest launch speed, in meters per second. When a projectile is launched, this is set to the launch speed.',
+ phetioDocumentation: 'This Property is the value displayed on the speed tool, in meters per second.' +
+ 'When a projectile is launched or selected, this is set to the launch speed of that projectile.',
phetioFeatured: true
} );
+ this.latestLaunchAngleProperty = new NumberProperty( this.meanAngleProperty.value );
+
+ this.latestLaunchSpeedProperty = new NumberProperty( 0 );
+
this.selectedProjectileNumberProperty = new NumberProperty( 0, {
phetioFeatured: true,
tandem: providedOptions.tandem.createTandem( 'selectedProjectileNumberProperty' ),
@@ -156,6 +167,16 @@
this.standardDeviationAngleProperty.lazyLink( () => {
this.latestLaunchAngleProperty.value = this.meanAngleProperty.value;
} );
+
+ // When the latest launch angle changes, update the displayed launch angle
+ this.latestLaunchAngleProperty.link( value => {
+ this.displayedLaunchAngleProperty.value = value;
+ } );
+
+ // When the latest launch speed changes, update the displayed launch speed
+ this.latestLaunchSpeedProperty.link( value => {
+ this.displayedLaunchSpeedProperty.value = value;
+ } );
}
private updateProjectileCounts(): void {
@@ -175,6 +196,9 @@
this.latestLaunchSpeedProperty.value = projectile.launchSpeed;
this.projectileLaunchedEmitter.emit( projectile );
+
+ this.latestLaunchAngleProperty.value = projectile.launchAngle;
+ this.latestLaunchSpeedProperty.value = projectile.launchSpeed;
}
public createLandedProjectile(): void {
```
terracoda
samreid
As recommended by @terracoda in https://github.com/phetsims/projectile-data-lab/issues/107#issuecomment-1986172915, When selecting an earlier projectile, the speedometer and angle gauge needle should indicate the selected projectile. When a new projectile is launched, it can show that data.