search

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Angle Stability - Update PhET-IO API to use new name and min/max #252

Closed matthew-blackman closed 3 months ago

matthew-blackman commented 4 months ago

The work done in https://github.com/phetsims/projectile-data-lab/issues/249 is looking great, and we should make sure that the PhET-IO API is consistent with the new naming convention. In studio, users should see 'Angle Stability' in cases where they are adjusting this slider, or looking at the properties of the mystery launchers.

Note: I don't think it is necessary to change the code that refers to the 'angle stabilizer'. This is an implementation detail, and we can consider the mechanism as the 'Angle Stabilizer', but the customizable variable is the 'Angle Stability'.

samreid commented 4 months ago

Note I already started using "Angle stability" terminology in the codap wrapper.

samreid commented 4 months ago

OK I renamed the variables, keeping "Angle stabilizer" where appropriate. I renamed variables or classes where appropriate. @matthew-blackman can you please review and clarify what should be done about min/max?

matthew-blackman commented 3 months ago

Reviewed and it looks like all references to angle stability are consistent with the UI. Nice work! Closing.