text shifts vertically when selecting different pumpkin projectiles

Nancy-Salpepi commented 3 months ago

Test device MacBook Air M1 chip and Chromebook

Operating System 14.3.1

Browser Safari 17.3.1/Chrome

Problem description For https://github.com/phetsims/qa/issues/1060, this is minor but on the first three screens I noticed that the text (X of X) on the field sign moves up and down and I arrow through all of the launched pumpkins. This doesn't happen with the cannonballs or the pianos.

Steps to reproduce

Launch a bunch of pumpkins
Continuously press the decrement button on the field sign

Visuals

https://github.com/phetsims/projectile-data-lab/assets/87318828/f303eccb-b80a-4164-8b8d-3a281786d56b

samreid commented 3 months ago

@matthew-blackman and I reproduced the problem and would like to solve it via maybe one of these approaches:

Top aligning the text
Pumpkins could take the same footprint
Pumpkins could stay center aligned as you switch instances

samreid commented 3 months ago

Fixed and ready for @matthew-blackman to review.

matthew-blackman commented 3 months ago

Things are looking great here. Nice work! I pushed a minor refactor, feel free to review @samreid. Closing.

phetsims / projectile-data-lab

text shifts vertically when selecting different pumpkin projectiles #259