samreid
commented
2 months ago I'm working on the recommendations above and it is mostly going well. However, I changed the headings to divs and it seems OK but I think we need some kind of separator between them.
This is with an <h5> which defaults to bold (but we can unbold it).
Anyways, here's a patch with adjustments in those areas. We should iterate with @matthew-blackman and @catherinecarter to see what's best:
```diff
Subject: [PATCH] Save/restore projectile checkboxes and simulation state in projectileDataWrapper.html, see https://github.com/phetsims/projectile-data-lab/issues/232
---
Index: repos/projectile-data-lab/wrappers/codap/projectileDataWrapper.html
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/repos/projectile-data-lab/wrappers/codap/projectileDataWrapper.html b/repos/projectile-data-lab/wrappers/codap/projectileDataWrapper.html
--- a/repos/projectile-data-lab/wrappers/codap/projectileDataWrapper.html (revision 5e0a1cd7662168304895ff3c2b3b59e6cecd9c1e)
+++ b/repos/projectile-data-lab/wrappers/codap/projectileDataWrapper.html (date 1713961765655)
@@ -59,9 +59,8 @@
}
.variableGroupHeading {
- font-family: 'Montserrat-Regular', sans-serif !important;
- font-size: 13px;
- font-weight: bold;
+ font-family: 'Arial, Montserrat-Regular', sans-serif;
+ font-size: 12px;
margin-left: 5px;
margin-top: 8px;
margin-bottom: 5px;
@@ -71,6 +70,11 @@
margin-top: 5px;
}
+ /*Make h5 not be bold*/
+ /*h5 {*/
+ /* font-weight: normal;*/
+ /*}*/
+
.checkboxContainer {
background-color: #e5e5e5;
width: 100%;
@@ -78,7 +82,6 @@
margin-left: 0;
margin-top: 2px;
margin-bottom: 2px;
- font-weight: bold;
display: flex;
align-items: center;
}
@@ -91,8 +94,8 @@
/* Styling for checkboxLabel class */
.checkboxLabel {
width: 100%;
- font-family: 'Montserrat-Regular', sans-serif !important;
- font-size: 12px;
+ font-family: 'Arial, Montserrat-Regular', sans-serif;
+ font-size: 11px;
padding-top: 2px;
padding-bottom: 2px;
padding-left: 5px;
@@ -109,7 +112,7 @@
matthew-blackman
commented
2 months ago
matthew-blackman
commented
2 months ago @catherinecarter @samreid and I reviewed this and made the above commit to remove the bold from the variable headings. Nice work! Closing.
The docked variables panel could be improved. Currently, all the variables are in bold and have a much larger font than the rest of the sim:
Also, the word, "Quantitative," could be changed to, "Numerical" to be more clear what these variables are.
To do: