Hotkeys for selecting fields and Chromebook keyboard shortcuts conflict

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

0 stars 0 forks source link

Hotkeys for selecting fields and Chromebook keyboard shortcuts conflict #266

Closed Nancy-Salpepi closed 3 months ago

Nancy-Salpepi commented 3 months ago

Test device Lenovo 100e Chromebook

Operating System ChomeOS 122.0.6261.118

Problem description For https://github.com/phetsims/qa/issues/1060, the hotkeys used to select a particular field (alt + 1 - 6) are also Chromebook shortcut keys for the icons in the dock. If I press alt + 6 on my Chromebook instead of going to field 6, a new window opened with the 6th app in my doc, which was youtube.

The shortcut is listed here: https://support.google.com/chromebook/answer/183101?hl=en#zippy=%2Csystem-display-settings.

Scroll down to "System and Display Settings" section.

matthew-blackman commented 3 months ago

@terracoda do you have a recommendation for alternative hotkey patterns that won't conflict with Chromebooks?

terracoda commented 3 months ago

I think it would be a good idea to use the J-key + Number key instead of the ALT + Number. Where's the original issue that brain-stormed some options?

matthew-blackman commented 3 months ago

I like that idea @terracoda. Here was the issue where we started discussing this, but it may be a bit stale - https://github.com/phetsims/projectile-data-lab/issues/44

terracoda commented 3 months ago

And issue #61 discussed ideas, too.

terracoda commented 3 months ago

Hopefully, there won't be any conflicts with ALT + L.

ALT is a very common modifier key. In Chromebook Shift + ALT + L highlights that platform's "Launcher" button.

Chromebook Shortcuts

ALT + L may be used in digital video players? PhET implemented ALT + L in MAL's TimingControlNode for the Step Forward button.

If you find a conflict, you might want to use F + L to "Fire Launcher" or J + L if you want to keep the first letter consistent with the field switcher.

samreid commented 3 months ago

I updated to use "J+(1-6)" and updated the keyboard help dialog. It sounds like there was no conflict with ALT+L and the J+1-6 matches the recommendations. Therefore it seems this issue can be closed.

samreid commented 3 months ago

@matthew-blackman requested to use F instead of J, and @terracoda and I thought this would be OK. We will do so.

samreid commented 3 months ago

Fixed, closing.