search

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Needle traces disappear when setting state #269

Closed Nancy-Salpepi closed 6 months ago

Nancy-Salpepi commented 6 months ago

Test device MacBook Air M1 chip and iPad 9th generation

Operating System 14.3.1 and 17.4

Browser Safari

Problem description For https://github.com/phetsims/qa/issues/1060 in the Studio and State wrappers on the first 3 screens: the launched sim won't show any previous needle marks on the speed and angle tools.

Steps to reproduce

  1. In the Studio wrapper, go to any screen aside from the Sampling screen.
  2. Check the Launch Angle and Launch Speed Checkboxes
  3. Launch a bunch of projectiles
  4. Press Test button

Visuals In Studio:

Screenshot 2024-03-21 at 1 05 10 PM

In Standard wrapper:

Screenshot 2024-03-21 at 1 05 30 PM
samreid commented 6 months ago

Fixed and working well in my testing. @matthew-blackman can you please review/test? Please close if all is well.

matthew-blackman commented 6 months ago

I reviewed this with @samreid and the code is very clear and straightforward. Behavior has been tested under a variety of circumstances and everything is working well. Nice work! Closing.