Closed pixelzoom closed 3 months ago
If you don't want default grab/release sounds, would it be possible to add this to PDLStopwatchNode? Then I could continue with https://github.com/phetsims/scenery-phet/issues/845.
dragListenerOptions: {
grabSound: null,
releaseSound: null
},
keyboardDragListenerOptions: {
grabSound: null,
releaseSound: null
}
Adding grab/release sound to MeasuringTapeNode is also pretty trivial, see https://github.com/phetsims/scenery-phet/issues/846.
@samreid and I discussed, and I'll proceed with adding default grab/release sounds to StopwatchNode and MeasuringTapeNode. I'll notify @samreid and @matthew-blackman when this work is completed -- probably on Monday 3/25.
Your options for this sim:
If the grab/release sounds are not desired for this sim, they can be turned off using grabSound: null
and releaseSound: null
options for RichDragListener and RichKeyboardDragListener.
If the grab/release sounds are desired for this, their output levels can be rebalanced via the grabSoundClipOptions
and releaseSoundClipOptions
options for RichDragListener and RichKeyboardDragListener.
@samreid @matthew-blackman FYI, work has been completed for default grab/release sounds in StopwatchNode and MeasuringTapeNode.
Looks good and working well in my testing. I believe this issue can be closed.
There are no default grab/release sounds for the stopwatch and measuring tape. My understanding is that we're adding these to all new sims that support UI sound. And it involves a quick conversion to RichDragListener and RichKeyboardDragListener.
The conversion for StopwatchNode can be found in the patch in https://github.com/phetsims/scenery-phet/issues/845#issuecomment-2013876745. I have not committed it because it would seem even more odd for the measuring tape to have no grab/release sound.