phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

No grab/release sounds for the stopwatch and measuring tape. #270

Closed pixelzoom closed 3 months ago

pixelzoom commented 3 months ago

There are no default grab/release sounds for the stopwatch and measuring tape. My understanding is that we're adding these to all new sims that support UI sound. And it involves a quick conversion to RichDragListener and RichKeyboardDragListener.

The conversion for StopwatchNode can be found in the patch in https://github.com/phetsims/scenery-phet/issues/845#issuecomment-2013876745. I have not committed it because it would seem even more odd for the measuring tape to have no grab/release sound.

pixelzoom commented 3 months ago

If you don't want default grab/release sounds, would it be possible to add this to PDLStopwatchNode? Then I could continue with https://github.com/phetsims/scenery-phet/issues/845.

      dragListenerOptions: {
        grabSound: null,
        releaseSound: null
      },
      keyboardDragListenerOptions: {
        grabSound: null,
        releaseSound: null
      }
pixelzoom commented 3 months ago

Adding grab/release sound to MeasuringTapeNode is also pretty trivial, see https://github.com/phetsims/scenery-phet/issues/846.

pixelzoom commented 3 months ago

@samreid and I discussed, and I'll proceed with adding default grab/release sounds to StopwatchNode and MeasuringTapeNode. I'll notify @samreid and @matthew-blackman when this work is completed -- probably on Monday 3/25.

Your options for this sim:

pixelzoom commented 3 months ago

@samreid @matthew-blackman FYI, work has been completed for default grab/release sounds in StopwatchNode and MeasuringTapeNode.

samreid commented 3 months ago

Looks good and working well in my testing. I believe this issue can be closed.