search

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Should I hear radiobutton sound when selecting field using hotkeys? #284

Closed Nancy-Salpepi closed 5 months ago

Nancy-Salpepi commented 5 months ago

Test device MacBook Air M1 chip

Operating System 14.4.1

Browser Safari 17.4.1

Problem description For https://github.com/phetsims/qa/issues/1068, on the first 3 screens I don't hear any sound when I switch fields using the hot keys. Should I hear the radio button sound here? It seems oddly quiet.

matthew-blackman commented 5 months ago

Good idea! This has been added in the commit. Feel free to close if it sounds okay to you.

Nancy-Salpepi commented 5 months ago

Sounds great! Since this is an RC, keeping open for verification in next RC.

Nancy-Salpepi commented 5 months ago

@matthew-blackman what are your thoughts on hearing a sound when I jump to the first/last projectile on the Field Sign using home and end keys?

matthew-blackman commented 5 months ago

@Nancy-Salpepi also oddly quiet. Can you open an issue?

matthew-blackman commented 5 months ago

Please close after verifying.

KatieWoe commented 5 months ago

Looks good in rc.2