Closed Nancy-Salpepi closed 2 months ago
also overlap when the launch angle is zero (although I'm not sure what can be done about any of these instances):
In discussion with @matthew-blackman, perhaps the readout could be above the measuring tape? That won't overlap other things and won't be occluded by a finger on mobile.
@matthew-blackman also recommends:
I addressed the recommendations above.
@matthew-blackman can you please review/test?
The updated layout and positioning looks good. Nice work @samreid! The distance text works well above the tape measure. I reviewed the commits and all are very straightforward. Marking as ready to cherry-pick.
Please close after verifying.
Only minor note is that the tape itself can cover important speed info when launching from a zero angle. If this is alright, it can be closed.
@matthew-blackman and I discussed it and agreed it is OK. Closing.
Test device MacBook Air M1 chip
Operating System 14.4.1
Browser Safari 17.4.1
Problem description For https://github.com/phetsims/qa/issues/1068, on the first 3 screens when the measuring tape is in the default position, the distance value may occlude Launch Angle value. This is seen with ?stringTest=dynamic.
Steps to reproduce
Visuals
https://github.com/phetsims/projectile-data-lab/assets/87318828/41bc7747-16bf-4654-88da-79723cd1ff3e