phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Distance and Launch Angle values overlap with ?stringTest=dynamic #286

Closed Nancy-Salpepi closed 2 months ago

Nancy-Salpepi commented 3 months ago

Test device MacBook Air M1 chip

Operating System 14.4.1

Browser Safari 17.4.1

Problem description For https://github.com/phetsims/qa/issues/1068, on the first 3 screens when the measuring tape is in the default position, the distance value may occlude Launch Angle value. This is seen with ?stringTest=dynamic.

Steps to reproduce

  1. Add ?stringTest=dynamic to url
  2. Go to any of the first 3 screens, and check Measuring Tape and Launch Angle checkboxes
  3. Press the right arrow key a couple of times

Visuals

https://github.com/phetsims/projectile-data-lab/assets/87318828/41bc7747-16bf-4654-88da-79723cd1ff3e

Nancy-Salpepi commented 3 months ago

also overlap when the launch angle is zero (although I'm not sure what can be done about any of these instances):

Screenshot 2024-04-10 at 3 56 13 PM
samreid commented 3 months ago

In discussion with @matthew-blackman, perhaps the readout could be above the measuring tape? That won't overlap other things and won't be occluded by a finger on mobile.

@matthew-blackman also recommends:

samreid commented 3 months ago

I addressed the recommendations above.

@matthew-blackman can you please review/test?

image image image
matthew-blackman commented 2 months ago

The updated layout and positioning looks good. Nice work @samreid! The distance text works well above the tape measure. I reviewed the commits and all are very straightforward. Marking as ready to cherry-pick.

matthew-blackman commented 2 months ago

Please close after verifying.

KatieWoe commented 2 months ago

Only minor note is that the tape itself can cover important speed info when launching from a zero angle. If this is alright, it can be closed. minornote

samreid commented 2 months ago

@matthew-blackman and I discussed it and agreed it is OK. Closing.