Launching doesn't resume after pressing Eraser button on Sampling Screen

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

0 stars 0 forks source link

Launching doesn't resume after pressing Eraser button on Sampling Screen #289

Closed Nancy-Salpepi closed 2 months ago

Nancy-Salpepi commented 3 months ago

Test device MacBook Air M1 chip

Operating System 14.4.1

Browser Safari and FF

Problem description For https://github.com/phetsims/qa/issues/1068, on the Sampling Screen, if the Eraser button is pressed while the sim is continuously launching, the Launch Button is still in 'play mode' but no projectiles are being launched.

Steps to reproduce

On the Sampling Screen, select Continuous mode
Press the Launch button
Press the Erase button

Visuals

https://github.com/phetsims/projectile-data-lab/assets/87318828/765b826b-3832-413f-aa6a-d1abc462f997

catherinecarter commented 3 months ago

@samreid, @matthew-blackman, and I discussed the desired behavior for the erase button on the Sampling screen. A summary of our discussion:

It was proposed that since the Sampling screen is different than the other screens, that the eraser should also act as a "stop" button to pause data being collected
It was proposed to have the eraser behave like the other screens by clearing the field but continue launching

Our decision was that consistency is important. Therefore, the decision is to have the erase button behave like the other screens:

If the user is in single launch mode (i.e. no projectiles are auto-launching) and presses the eraser, the field and histogram clears, the button remains in single launch mode
If the user is in continuous launch mode (i.e. projectiles are auto-launching) and presses the eraser, the field and histogram clears, and the button remains in continuous mode, hence projectiles continue to come out

matthew-blackman commented 3 months ago

Labeling this for additional QA scrutiny since it adds a little bit of complexity to an already complex part of the sim. Testing combinations of single/continuous modes and switching between them, along with clearing data, may reveal further edge cases.

Nancy-Salpepi commented 3 months ago

@samreid @matthew-blackman this doesn't appear to be fixed. If I follow the same steps as in my original comment, I get the same result as in the video.

matthew-blackman commented 2 months ago

Sorry for the false alarm! @samreid and I worked on this and fixed the behavior in the latest commit. It should be ready to test now.

Nancy-Salpepi commented 2 months ago

Looks good to me on main!

matthew-blackman commented 2 months ago

We also tested this with @catherinecarter and all looks well. The commits above are ready to cherry-pick.

matthew-blackman commented 2 months ago

Please close after verifying.

KatieWoe commented 2 months ago

Looks good in rc.2