Should standardLauncherRadioButton be named mysteryLauncherRadioButton?

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

0 stars 0 forks source link

Should standardLauncherRadioButton be named mysteryLauncherRadioButton? #291

Closed Nancy-Salpepi closed 2 months ago

Nancy-Salpepi commented 3 months ago

Test device MacBook Air M1 chip

Operating System 14.4.1

Browser Firefox

Problem description For https://github.com/phetsims/qa/issues/1068, in studio on the Measures screen, I see that the Mystery Launcher Radio Button is called standardLauncherRadioButton in the tree. Should this be mysteryLauncherRadioButton? I don't see standardLauncher elsewhere.

Visuals

matthew-blackman commented 3 months ago

Yes it should. Good find @Nancy-Salpepi! Updated in the commit.

Nancy-Salpepi commented 3 months ago

looks good in main.

samreid commented 3 months ago

I additionally regenerated the API file. The new API needs to be included in the cherry pick

matthew-blackman commented 2 months ago

Please close after verifying.

KatieWoe commented 2 months ago

Looks good in rc.2