search

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Possible to select a field using hotkeys when radio button is disabled/not visible #294

Closed Nancy-Salpepi closed 5 months ago

Nancy-Salpepi commented 5 months ago

Test device MacBook Air M1 chip : Operating System 14.4.1

Browser Chrome

Problem description For https://github.com/phetsims/qa/issues/1068, in Studio on the first 3 screens: It is still possible to access a field using the hotkeys after making that field's radio button disabled or invisible.

Steps to reproduce Here is an example:

  1. In studio, make projectileDataLab.measuresScreen.view.fieldRadioButtonGroup.field5RadioButton.visibleProperty false
  2. Press the Test button
  3. Press F + 5 OR
  4. Make projectileDataLab.measuresScreen.view.fieldRadioButtonGroup.field5RadioButton.enabledProperty false
  5. Press the Test button
  6. Press F + 5

Visuals

Screenshot 2024-04-15 at 1 08 38 PM Screenshot 2024-04-15 at 1 11 49 PM
matthew-blackman commented 5 months ago

This is fixed in my testing and the commit looks good. Nice work @samreid! Marking this as ready for review.

Nancy-Salpepi commented 5 months ago

This is working nicely in main.

matthew-blackman commented 5 months ago

Please close after verifying.

KatieWoe commented 5 months ago

Looks ok in rc.2