search

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Sample appears when stopping continuous sampling #295

Closed matthew-blackman closed 5 months ago

matthew-blackman commented 5 months ago

To trigger this behavior:

  1. Start continuous sampling
  2. Pause the sim
  3. Press the clear button
  4. Press the button to stop continuous sampling (while still paused)

The sim's current behavior is that it will erroneously create a sample on step 4. This sample should not appear. All other behavior should stay the same. Let's fix it!

matthew-blackman commented 5 months ago

This is fixed in the commit. @KatieWoe and @Nancy-Salpepi please confirm. @samreid and I also wanted to bring attention here for further testing, as we feel that additional edge cases in this area are likely.

KatieWoe commented 5 months ago

Looks ok on main. We'll keep an eye out for similar issues in the next test.

Nancy-Salpepi commented 5 months ago

Looks good to me too.

matthew-blackman commented 5 months ago

Please close after verifying.

KatieWoe commented 5 months ago

Looks good in rc.2