phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

CODAP Wrapper: Add docked variables for screenIdentifier and sampleSize #313

Closed matthew-blackman closed 6 months ago

matthew-blackman commented 7 months ago

Let's add variables to the CODAP wrapper for screenIdentifier and sampleSize. SampleSize is technically available in the 'Field' variable for the Sampling screen, but @catherinecarter and I discussed that it may not be obvious to users that the sample number is part of the field identifier string. We would like to allow for multiple ways for users to differentiate the sample means and individual projectile data, so it makes sense to also have a 'Sample Size' variable (numeric).

samreid commented 6 months ago

For the sampling screen, we will parse the field ID to get the sample size. a) For the other screens, the sample size will be the same as the total number of landed projectiles at that moment. But that "at that moment" part means it will become inconsistent when another projectile lands. Therefore we choose to go with (b): b) For the other screens, the sample size will be blank We need a checkbox, and a query parameter.

samreid commented 6 months ago

Code looks good. Runtime looks good:

image

I also tested with projectileDataWrapper.html?sim=projectile-data-lab%26screens=2,4%26sampleSize=false and it behaved as expected. This looks ready to close. @matthew-blackman anything else before closing?

matthew-blackman commented 6 months ago

Great! Let's continue the offshoot work in https://github.com/phetsims/projectile-data-lab/issues/333. Closing.