search

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Screen identifiers should not include the word 'screen' #314

Closed matthew-blackman closed 2 months ago

matthew-blackman commented 2 months ago

Discussing this with @catherinecarter, we agreed that makes the identifiers too long. Let's use 'variability', 'sources', 'measures', 'sampling' instead of 'variabilityScreen', 'sourcesScreen', 'measuresScreen', 'samplingScreen'.

matthew-blackman commented 2 months ago

This has been implemented in the commit. Marking to cherry-pick.

matthew-blackman commented 2 months ago

The above commit uses the screen identifier values instead of tandem names, as well as adds support for the the screen identifier variable to the CODAP wrapper. Marking ready to cherry-pick.

matthew-blackman commented 2 months ago

Please close after verifying.

KatieWoe commented 2 months ago

Unless I'm misunderstanding this issue, this doesn't seem to have occurred notthecase

catherinecarter commented 2 months ago

@KatieWoe - I believe this issue is referring to what string will be passed into CODAP as the title of a column heading. I don't believe this is meant to refer to the PhET-iO ID in studio.

KatieWoe commented 2 months ago

In that case, what should I check in rc.2?

catherinecarter commented 2 months ago

Oh shoot! I meant the contents of the column not the column heading.

So what to look for... I believe it would be to make sure that if you launch projectiles on one screen, let's just say launcher 4 on the Variability Screen, and then you launch the same launcher from a different screen, say launcher 4 on the Measures Screen, then the contents of the "screen" column in the table would say, "Variability" and "Measures," respectively.

Does that make sense?

The purpose is to delineate which screen the launches came from, in case anyone wanted to recreate the histogram per screen without combining data in an unwanted way.

KatieWoe commented 2 months ago

We haven't been given anything to do with codap in these tests. I was told that would be next release. I don't know how to check this table.

catherinecarter commented 2 months ago

Gotcha. We will await instructions from @matthew-blackman and @samreid. I don't have the link to take a look myself. Thanks, Katie!

KatieWoe commented 2 months ago

Discussed on zoom. This was checked by examining the state using code from the examples doc. Things look ok, closing.