search

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Should the histogram sound button be disabled when sound is off? #319

Closed Nancy-Salpepi closed 5 months ago

Nancy-Salpepi commented 5 months ago

Test device MacBook Air M1 chip

Operating System 14.4.1

Browser Safari 17.4.1

Problem description For https://github.com/phetsims/qa/issues/1079, I noticed that the histogram sound button is still enabled when the sound is off. I looked at Number Compare and Number Play and the Sound button (megaphone) is disabled when the sound is off.

Steps to reproduce

  1. On any screen launch some projectiles
  2. Turn off the sound in the nav bar

Visuals

Here is what Number Play looks like:

https://github.com/phetsims/projectile-data-lab/assets/87318828/279602bb-1d04-4ef2-81d4-a32f26ab0092

matthew-blackman commented 5 months ago

Great find @Nancy-Salpepi! This is fixed in the commit, and we also added a line of code to stop the histogram data sound/animation highlighting when the sim is muted. Can you test/confirm that this is working correctly on main?

Nancy-Salpepi commented 5 months ago

Looks good on main in both sims!

KatieWoe commented 5 months ago

Looks good in both