search

phetsims / projectile-data-lab

"Projectile Data Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 0 forks source link

Preferences query parameter strings should match preferences menu labels #322

Closed matthew-blackman closed 2 months ago

matthew-blackman commented 2 months ago

When building the teacher tips, I noticed that the query parameters for 'binStrategy' and 'launchSoundStrategy' did not match the labels used in the Preferences menu. Let's change these to 'histogramBins' and 'launchSound' so that they match the UI.

matthew-blackman commented 2 months ago

Please close after confirming that this is fixed.

kathy-phet commented 2 months ago

Good catch, @matthew-blackman

matthew-blackman commented 2 months ago

This has been fixed and cherry picked into 1.0. Closing.