samreid
commented
1 month ago Experimental patch:
```diff
Subject: [PATCH] Only consider landeded projectiles for determining if a sample is complete, see https://github.com/phetsims/projectile-data-lab/issues/329
---
Index: js/sampling/model/SamplingField.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/sampling/model/SamplingField.ts b/js/sampling/model/SamplingField.ts
--- a/js/sampling/model/SamplingField.ts (revision 4d9eec05c31fd71b49a92004e4f6cc5e2c344b66)
+++ b/js/sampling/model/SamplingField.ts (date 1715707819562)
@@ -177,6 +177,10 @@
this.updateComputedProperties();
} );
+ this.projectileLandedEmitter.addListener( () => {
+ this.updateComputedProperties();
+ } );
+
Tandem.PHET_IO_ENABLED && phet.phetio.phetioEngine.phetioStateEngine.stateSetEmitter.addListener( () => {
this.updateComputedProperties();
} );
@@ -210,7 +214,7 @@
this.numberOfStartedSamplesProperty.value - 1;
// Update the sample mean
- const projectilesInSelectedSample = this.getProjectilesInSelectedSample();
+ const projectilesInSelectedSample = this.getLandedProjectilesInSelectedSample();
// This multilink is called during transient intermediate phases, so we must guard and make sure we truly have a complete sample
const isComplete = this.phaseProperty.value === 'showingCompleteSampleWithMean' && projectilesInSelectedSample.length === this.sampleSize;
zepumph
In both PDL and PSD: