FieldIO instrumentation simplifications

pixelzoom commented 4 months ago

PDL was used as an exemplar for instrumenting Gas Properties. While working on https://github.com/phetsims/gas-properties/issues/77 and https://github.com/phetsims/gas-properties/issues/231 with @zepumph, we noted the following things about the implementation of FieldIO:

[x] toStateObject is unnecessary. The default implementation that is derived from stateSchema does the same thing.
[x] defaultDeserializationMethod is unnecessary. (Ask @zepumph why.)
[x] applyState would be unnecessary if stateSchema used ReferenceArrayIO instead of ArrayIO. See ReferenceArrayIO's default applyState (line 37).

According to @zepumph, the above changes will change the PhET-iO API, but will not require migration processors.

samreid commented 4 months ago

I applied the changes above and tested in the state wrapper (I tested a VSM screen and the sampling screen). Seems to be working OK. @matthew-blackman can you please review/test?

matthew-blackman commented 3 months ago

Reviewed and tested. This is working well and the code looks great. Nice job! Closing.

phetsims / projectile-data-lab

FieldIO instrumentation simplifications #330