Closed Nancy-Salpepi closed 2 months ago
@catherinecarter interested in your thoughts. Do you feel that Field can be removed for the PSD table, since that info is available through a combination of Launcher and Sample Size? Or is it more convenient in CODAP to have them wrapped up in a unique identifier for each independent data set?
I tested it out a bit, and having them separate is actually better. It's more clear to the user when checking the checkboxes for launcher and sample size, that they aren't wrapped together under the word, "Field," which is not as intuitive as a label.
I think Field can be removed, as long as the launcher and sample size are still available as variables to choose.
I do think that if the Launcher checkbox is defaulted to be checked, the sample size should also be defaulted to checked since they go hand-in-hand. Which is what the current Field checkbox is currently intended to do, I believe.
In summary:
Adding another comment:
We will need to improve the Help dialog box. The pathway to get a graph of the sample size/launcher combos, while also calculating the mean per sample is quite a bear (see image below). I'll brainstorm ideas.
@catherinecarter this is ready for review. I'll make a separate issue for the Help dialog on PSD.
I'm still seeing the Field and caseIndex columns, and the sample number/size are unchecked. I was checking dev.3. Am I in the correct version?
Looks great. Much cleaner and easier to parse.
For https://github.com/phetsims/qa/issues/1099; There aren't different fields in PSD but there is a Field checkbox. In the data table the Field column lists the launcher and the sample size. Wondering if the Field variable checkbox is needed since the Launcher and Sample Size have their own checkboxes or if it is needed, should it have a different name?