search

phetsims / projectile-motion

"Projectile Motion" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
15 stars 13 forks source link

Replace usages of _.defaults with PHET_CORE/merge #194

Closed zepumph closed 4 years ago

zepumph commented 4 years ago

Though this is a fine pattern, it is atypical to use for our options, and merge is preferred, if only because it is a pattern used across the whole project. For example I had never seen this function until beginning to work on this sim, and I had to look it up. While that isn't inherently enough to warrant a conversion, I think it would help clean up the code.

zepumph commented 4 years ago

@samreid, I want to appreciate and respect developer discretion. That said do you think that this issue is worth doing?

samreid commented 4 years ago

It seems better to use merge for sim options.