phetsims / projectile-motion

"Projectile Motion" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
15 stars 13 forks source link

Use PhetColorScheme.VELOCITY and PhetColorScheme.ACCELERATION #233

Closed arouinfar closed 3 years ago

arouinfar commented 3 years ago

In https://github.com/phetsims/scenery-phet/issues/621 we modernized the colors used for velocity and acceleration.

This sim currently uses similar colors for the velocity and acceleration fills, but should be updated to use PhetColorScheme. https://github.com/phetsims/projectile-motion/blob/master/js/common/ProjectileMotionConstants.js#L57-L58

Assigning @zepumph since this change should be included in the next release and he's currently serving as interim responsible-dev while iO work is ongoing.

zepumph commented 3 years ago

Sounds good. I used the constants (always love a constant!), but the values were already the same, so there is no change in output. Closing.