Tweaks to projectileControlPanel

phetsims / projectile-motion

"Projectile Motion" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

15 stars 13 forks source link

Tweaks to projectileControlPanel #250

Closed arouinfar closed 2 years ago

arouinfar commented 3 years ago

For #244

[ ] Instrument the separator lines in the projectileControlPanels to avoid situations like the screenshot below. See phScale.microScreen.view.beakerControlPanel.separator for an example in action. When there multiple separators in a panel call them separator1 and separator2.
[x] In projectileMotion.vectorsScreen.view.projectileControlPanel, instrument the "Cannonball" title as titleNode with visibleProperty and textProperty children. The cannonball icon does not need to be separately instrumented, but its visibility should listen to titleNode.visibleProperty.
[ ] On the Drag screen, the icon next to the "Drag Coefficient" should be hidden when projectileMotion.dragScreen.view.projectileControlPanel.dragCoefficientNumberControl.titleNode.visibleProperty is false.

zepumph commented 3 years ago

(1) See elements like projectileMotion.labScreen.view.projectileControlPanel.separator2.visibleProperty

(2) Done.

(3) This is actually harder than I thought. We don't have access to NumberControl's titleNode from outside the type, so I can't toggle visibility of dragObjectDisplay based on it. I'll have to keep thinking about it.

@arouinfar please review. How important is (3)?

zepumph commented 3 years ago

Sorry for the late commit coming in for (2)

arouinfar commented 3 years ago

Items (1) & (2) look good!

(3) This is actually harder than I thought. We don't have access to NumberControl's titleNode from outside the type, so I can't toggle visibility of dragObjectDisplay based on it. I'll have to keep thinking about it.

@arouinfar please review. How important is (3)?

Listening to dragCoefficientNumberControl.titleNode.visibleProperty isn't necessary. However, it'd be really nice to be able to hide the dragObjectDisplay. Could it be separately instrumented?

zepumph commented 3 years ago

Instrumented above. We now have projectileMotion.dragScreen.view.projectileControlPanel.dragObjectDisplay.visibleProperty

arouinfar commented 2 years ago

Looks good in master, thanks @zepumph.