search

phetsims / projectile-motion

"Projectile Motion" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
15 stars 13 forks source link

Renaming model properties related to target #251

Closed arouinfar closed 3 years ago

arouinfar commented 3 years ago

For #244

The model properties related to the targetNode are housed under model.score which we don't find to be particularly intuitive.

Model View
image image

Things we'd like to rename:

zepumph commented 3 years ago

Change model.score to model.target

This was not just a tandem rename, but instead a whole class, so I did this in https://github.com/phetsims/projectile-motion/issues/268

zepumph commented 3 years ago

All has been complete here, please review.

arouinfar commented 3 years ago

Looks good in master, thanks!