Add titleNode to labScreen.view.initialValuesPanel

phetsims / projectile-motion

"Projectile Motion" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

15 stars 13 forks source link

Add titleNode to labScreen.view.initialValuesPanel #256

Closed arouinfar closed 3 years ago

arouinfar commented 3 years ago

For #244

This is labScreen.view.initialValuesPanel

We'd like to instrument the "Initial Values" title and give it a visibleProperty and textProperty. The tree structure would look like this:

initialValuesPanel
    visibleProperty
  + angleReadout
  + heightReadout
  - titleNode
       textProperty
       visibleProperty
  + velocityReadout

zepumph commented 3 years ago

It seems like most of this happened two days after opening this issue in https://github.com/phetsims/projectile-motion/commit/b703492f325720fe833ba55e832ae225eddb4bb5, as part of #219, but I don't see a paper trail on that structure over there. Added a titleNode, but that is all.

Anyways. . . .

Please review in master, the readout textProperties are phetioReadOnly: true, is that correct?

arouinfar commented 3 years ago

The new titleNode looks good in master.

the readout textProperties are phetioReadOnly: true, is that correct?

Yes, that's correct. The readout text should match the actual data in the sim.