Should we do anything about the "hello" keypad easter egg?

phetsims / projectile-motion

"Projectile Motion" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

15 stars 13 forks source link

Should we do anything about the "hello" keypad easter egg? #266

Closed samreid closed 3 years ago

samreid commented 3 years ago

Discovered in #265, the keypad will say hello using 43110 (lowercase ll) but not 43770 (uppercase L):

@jbphet is listed as the responsible dev in the spreadsheet, but I (mis?)recalled @zepumph was working on this sim. I'll assign both just in case.

jbphet commented 3 years ago

@samreid - I just took a look at this functionality in the sim, and I'm not sure why it exists. It might be something that @andrealin was experimenting with, perhaps as she was learning about how to write PhET sims. The functionality doesn't seem particularly important to me, so I'm wondering why it you've logged a bug about it not supporting upper case 'L' values. Can you please clarify why you think this is worth spending time on?

samreid commented 3 years ago

It's probably just an easter egg, I was surprised to see it and it caused a minor complication (which I've already corrected) in https://github.com/phetsims/projectile-motion/issues/265. Just wanted to raise awareness, the easter egg adds a little bit of code that needs to be maintained, and didn't work like I expected. Up to you how to proceed, if at all.

UPDATE: To clarify, I'm happy with any of the following choices (despite the phrasing of the issue title)

Leave it as it is now
Add support for 77
Remove the easter egg

samreid commented 3 years ago

I updated the title to make it clearer how we might proceed.

jbphet commented 3 years ago

It sounds like the problem has been corrected, and I don't mind the occasional, small, non-obtrusive Easter egg. Let's just leave it as is. Closing.