Open zepumph opened 2 years ago
Any updates on this? @zepumph @arouinfar
@arouinfar would have the knowledge about how we do this in other sims. I no longer feel like zoomFactorProperty
makes sense. I would comfortably say a sentence like "it has a zoom of 2x" and "factor" would just be confusing. @arouinfar, do you agree? I can update the phetioDocumentation accordingly.
When we pick this sim back up, we should follow the pattern used in Geometric Optics. There are two properties related to zoom:
zoomLevelProperty
which the integer index controlled by the zoom buttons and is phetioReadOnly: false
.zoomScaleProperty
which is derived from zoomLevelProperty
and corresponds to the magnification level. It is equivalent to the zoomProperty
in Projectile Motion.Since this sim is currently on hold, I'm going to unassign myself.
While working on https://github.com/phetsims/projectile-motion/issues/275, I had two questions about the zoomProperty, mostly in a PhET-iO context, but also for general maintainability.
zoomFactorProperty
, because I feel like in general it is hard to understand the unit for the Property, when I read the phetioDocumentation, it makes so much more sense: ". . .Each new zoom level increases the value by a factor of 2." Why not just make it more clear in the name?