Closed zepumph closed 1 year ago
@matthew-blackman has this change set committed locally, over to him to finish off the issue.
https://github.com/phetsims/chipper/commit/dc585fc3259347d24e1989e8812e4cf067d20d4d was committed but it didn't link back here, so I commented in the commit so that it was linked back here. I see that it added a repo called 'projectile-motion '
. Which included the space after it. So this isn't yet turned on. When I remove the space and lint, I still see 5 errors in the repo, presumably these have been fixed on @matthew-blackman's computer locally, but are not yet on master. I will not commit this patch here until we don't have lint problems, so that we don't break testing in the interim.
Index: eslint/rules/todo-should-have-issue.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/eslint/rules/todo-should-have-issue.js b/eslint/rules/todo-should-have-issue.js
--- a/eslint/rules/todo-should-have-issue.js (revision 974ada762a80b7652dd0c3652dd2695f54dac965)
+++ b/eslint/rules/todo-should-have-issue.js (date 1665601152836)
@@ -18,7 +18,7 @@
}
// List of directories to check that TODOs have GitHub issues
-const directoriesToRequireIssues = [ 'projectile-motion ' ];
+const directoriesToRequireIssues = [ 'projectile-motion' ];
if ( buildJSON && buildJSON.common && buildJSON.common.phetLibs ) {
// Don't require issues in these repos:
Projectile Motion now has the todo-should-have-issue lint rule.
@matthew-blackman and I would like this sim to be forced to have TODOs have issues. Let's make it happen!