search

phetsims / projectile-motion

"Projectile Motion" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
15 stars 13 forks source link

Commented out fill #321

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

I'm not sure why this fill was commented out in https://github.com/phetsims/projectile-motion/commit/cd31d599d11d63b4c081aaa9a80a82388bb1904f#diff-4d3815a80bd73740931e387e7d9233b843e4c5c0c9acfdbaad565219ba8db5bdR454

https://github.com/phetsims/projectile-motion/blob/master/js/common/view/ProjectileMotionScreenView.ts#L435

Any thoughts @matthew-blackman?

matthew-blackman commented 1 year ago

Good find! I uncommented the line and updated the property to iconFill. Tested and it's propagating into the step button. If all looks good this can be closed.