phetsims / proportion-playground

"Proportion Playground" is an educational simulation in HTML5, by PhET Interactive Simulations at the University of Colorado Boulder.
GNU General Public License v3.0
2 stars 4 forks source link

review model.md #79

Closed pixelzoom closed 7 years ago

pixelzoom commented 7 years ago

Related to #69 (code review).

From the code-review checklist:

  • [ ] Does model.md adequately describe the model, in terms appropriate for teachers?

@amanda-phet Would you please review model.md? Does it have an appropriate level of detail, and the correct language, for its audience?

pixelzoom commented 7 years ago

@jonathanolson I'm having trouble groking this sentence:

It's equivalent to traveling across a (width/gcd)x(height/gcd) rectangle from one corner to another, thus with (width+height)/gcd bumps/endpoints, and a total distance of widthlengthsqrt(2)/gcd^2.

... specifically the "thus with (width+height)/gcd bumps/endpoints" part.

jonathanolson commented 7 years ago

Clarified wording. @pixelzoom, is that better? It was definitely confusing beforehand.

pixelzoom commented 7 years ago

Yep, that makes much more sense, thanks.

Back to @amanda-phet to decide if model.md is sufficient for teachers.

amanda-phet commented 7 years ago

This is for teachers? I think that the wording is fine and understandable, but I wouldn't add this detail to something like teacher tips.

I'm not totally sure what this model.md documentation is really for. I've never reviewed this in the past.

jonathanolson commented 7 years ago

I think (?) it's purpose is so we can direct teachers who ask questions about how the model works to that file (or refer to it when asking questions)?

amanda-phet commented 7 years ago

I think it is clear enough for this purpose.

pixelzoom commented 7 years ago

model.md provides a high-level description of the model. It's intended for audiences that are not necessarily technical. It's what we point people to who ask "how does the model work?"