search

phetsims / qa

Quality Assurance Task Tracking
MIT License
12 stars 8 forks source link

Check appearance of fonts in different locales #1036

Closed jonathanolson closed 7 months ago

jonathanolson commented 7 months ago

I committed a change onto main in https://github.com/phetsims/website-meteor/issues/656 that adjusts the fallback fonts to work around a Safari SVG issue (noticed for locales bn/th/hi).

I'd really appreciate testing if we can try across browsers/locales (however seems appropriate) to make sure that this change:

(a) doesn't degrade font/text appearance for any translated locale/browser combos (b) doesn't miss any locales where the effects of https://github.com/phetsims/website-meteor/issues/656 are seen in Safari (or... other browsers).

I don't exactly know what testing to recommend, but at a minimum:

@KatieWoe thoughts?

I'd like to do a maintenance patch (or... include this in the other maintenance) if it works out fine.

KatieWoe commented 7 months ago

I think this sounds alright. I think the non-English locales should be tested on other platforms for at least one sim. Would you want this tested on main, or in the maintenance release?

jonathanolson commented 7 months ago

On main would be great!

jonathanolson commented 7 months ago

Assorted links for testing (generated with perennial node js/scripts/locale-sim-list.js --limit=5 --production --phettest)

af (Afrikaans)

ak (Akan)

am (Amharic)

ar (Arabic)

ar_MA (Arabic, Morocco)

ar_SA (Arabic, Saudi Arabia)

ay (Aymara)

az (Azerbaijani)

be (Belarusian)

bg (Bulgarian)

bi (Bislama)

bn (Bengali)

bo (Tibetan)

bs (Bosnian)

ca (Catalan)

cs (Czech)

cy (Welsh)

da (Danish)

de (German)

ee (Ewe)

el (Greek)

en (English)

en_CA (English, Canada)

es (Spanish)

es_CO (Spanish, Colombia)

es_ES (Spanish, Spain)

es_MX (Spanish, Mexico)

es_PE (Spanish, Peru)

et (Estonian)

eu (Basque)

fa (Persian)

fi (Finnish)

fo (Faroese)

fr (French)

ga (Irish)

gl (Galician)

gu (Gujarati)

ha (Hausa)

hi (Hindi)

hr (Croatian)

ht (Haitian)

hu (Hungarian)

hy (Armenian)

ig (Igbo)

in (Indonesian)

is (Icelandic)

it (Italian)

iw (Hebrew)

ja (Japanese)

ka (Georgian)

ki (Kikuyu)

kk (Kazakh)

km (Khmer)

kn (Kannada)

ko (Korean)

ku (Kurdish)

ku_TR (Kurdish, Turkey)

lg (Ganda)

lo (Lao)

lt (Lithuanian)

lv (Latvian)

mg (Malagasy)

mi (Maori)

mk (Macedonian)

ml (Malayalam)

mn (Mongolian)

mo (Moldavian)

mr (Marathi)

ms (Malay)

mt (Maltese)

my (Burmese)

nb (Norwegian Bokmal)

ne (Nepali)

nl (Dutch)

nn (Norwegian Nynorsk)

ny (Chichewa)

om (Oromo)

or (Oriya)

pl (Polish)

ps (Pashto)

pt (Portuguese)

pt_BR (Portuguese, Brazil)

qu (Quechua)

ro (Romanian)

ru (Russian)

rw (Kinyarwanda)

sd (Sindhi)

se (Northern Sami)

sh (Serbo-Croatian)

si (Sinhalese)

sk (Slovak)

sl (Slovenian)

sn (Shona)

sq (Albanian)

sr (Serbian)

st (Sotho)

sv (Swedish)

sw (Swahili)

ta (Tamil)

te (Telugu)

tg (Tajik)

th (Thai)

ti (Tigrinya)

tk (Turkmen)

tl (Tagalog)

tn (Tswana)

tr (Turkish)

tw (Twi)

uk (Ukrainian)

ur (Urdu)

uz (Uzbek)

vi (Vietnamese)

wo (Wolof)

xh (Xhosa)

yo (Yoruba)

zh_CN (Chinese, Simplified)

zh_HK (Chinese, Hong Kong)

zh_TW (Chinese, Traditional)

zu (Zulu)

jonathanolson commented 7 months ago

Saw a good number of broken bits

I'll look into another patch to see if I can find a good backup font.

jonathanolson commented 7 months ago

Also I'm noticing that in some sims it is much more likely to show issues (acid-base-solutions, balloons-and-static-electricity, etc.)

kathy-phet commented 7 months ago

@jonathanolson - This is just on Safari, correct?

jonathanolson commented 7 months ago

Just Safari. I'll hopefully have improved testing in just a bit.

jonathanolson commented 7 months ago

My latest workaround now just affects Safari, and will be most likely to affect appearance in:

Sometime it would be good to talk through a testing strategy. Here's a fairly exhaustive list of what could be affected, perhaps some spot checks are worth it. (Now, the only thing that changes is if Safari is being run, so we'd only need to test Safari).

Perhaps some spot-checks that (a) this fixes the affected locales noted above, and (b) doesn't break RTL sims?

Nancy-Salpepi commented 7 months ago

I did spot checks on the following sims on main by adding locales=* to the end of the url: Acid-Base Solutions, Area Model Multiplication, Build a Nucleus, Center and Variability, Number Line: Distance and a bit on Balloons and Static Electricity. I also checked the About dialog in the PhET Menu, tabs in Preferences and the Keyboard dialog.

Nancy-Salpepi commented 7 months ago

@jonathanolson let QA know if there is anything else that needs to be done at this point or any other sims you think would be good to test.

jonathanolson commented 7 months ago

Thanks, that sounds great!

Nancy-Salpepi commented 7 months ago

Adding comment to different issue. Closing this again.