phetsims / qa

Quality Assurance Task Tracking
MIT License
12 stars 8 forks source link

Identify sims that have Safari 17.4 quadratic rendering problem #1069

Open pixelzoom opened 3 months ago

pixelzoom commented 3 months ago

In https://github.com/phetsims/graphing-quadratics/issues/206, @Nancy-Salpepi discovered a bug in Safari 17.4 on Apple chips. That bug was related to using SVG to draw quadratic curves, and was resolved for graphing-quadratics.

The bug is being tracked more generally in https://github.com/phetsims/scenery/issues/1628.

In https://github.com/phetsims/graphing-quadratics/issues/206#issuecomment-2032904300, @kathy-phet said:

@Nancy-Salpepi @KatieWoe - Sounds like you should keep an eye out for additional related issues to this on other sims.

According to @jonathanolson, sims that use these methods of kite.Shape are liable to have this problem:

Sims that call one or more of those methods directly include:

One or more of those methods are also used in these scenery-phet UI components:

BicyclePumpNode (used to draw the pump handle and front edge)

ProbeNode

ReturnButton / ReturnIcon

pixelzoom commented 3 months ago

@KatieWoe You'll probably want to check with @kathy-phet to confirm that this is a project worth doing, or whether to wait until problems are reported.

This is obviously a huge amount of stuff to test. And without assistance from the sim developer, it's not at all clear what should even be tested. For the sims that I'm familar with, I've provided details above.

It's also possible that @jonathanolson might be able to prune this task down a bit. Also worth following up on where @jonathanolson is with reporting this problem to the WebKit team for https://github.com/phetsims/scenery/issues/1628, and whether a fix for Safari 17.4 is forthcoming.

KatieWoe commented 1 month ago

QA is done

pixelzoom commented 1 month ago

This is obviously a huge amount of stuff to test. And without assistance from the sim developer, it's not at all clear what should even be tested.

@KatieWoe Can you please summarize what was tested, and what the results were?

Also worth following up on where @jonathanolson is with reporting this problem to the WebKit team for https://github.com/phetsims/scenery/issues/1628, and whether a fix for Safari 17.4 is forthcoming.

And did someone follow up on this?