phetsims / qa

Quality Assurance Task Tracking
MIT License
13 stars 8 forks source link

Maintenance Testing for Firefox SVG RTL Text #1106

Closed jonathanolson closed 4 months ago

jonathanolson commented 4 months ago

Patches are meant to fix https://github.com/phetsims/scenery/issues/1643.

It would be good to quickly test with Firefox 128+ on all links with ?locale=ar (or dynamic locale => Arabic if possible), along with a quick test to make sure there aren't regressions in how text is handled.

In particular, I'd like to ensure that switches between LTR and RTL and back work (if possible)

acid-base-solutions 1.3 (https://github.com/phetsims/scenery/issues/1643)

area-builder 1.1 (https://github.com/phetsims/scenery/issues/1643)

area-model-algebra 1.3 (https://github.com/phetsims/scenery/issues/1643)

area-model-decimals 1.3 (https://github.com/phetsims/scenery/issues/1643)

area-model-introduction 1.3 (https://github.com/phetsims/scenery/issues/1643)

area-model-multiplication 1.3 (https://github.com/phetsims/scenery/issues/1643)

arithmetic 1.2 (https://github.com/phetsims/scenery/issues/1643)

atomic-interactions 1.2 (https://github.com/phetsims/scenery/issues/1643)

balancing-act 1.3 (https://github.com/phetsims/scenery/issues/1643)

balancing-chemical-equations 1.2 (https://github.com/phetsims/scenery/issues/1643)

balloons-and-static-electricity 1.3-phetio (https://github.com/phetsims/scenery/issues/1643)

balloons-and-static-electricity 1.5 (https://github.com/phetsims/scenery/issues/1643)

beers-law-lab 1.7 (https://github.com/phetsims/scenery/issues/1643)

bending-light 1.1 (https://github.com/phetsims/scenery/issues/1643)

blackbody-spectrum 1.0 (https://github.com/phetsims/scenery/issues/1643)

build-a-fraction 1.0 (https://github.com/phetsims/scenery/issues/1643)

build-a-molecule 1.0 (https://github.com/phetsims/scenery/issues/1643)

build-a-nucleus 1.1 (https://github.com/phetsims/scenery/issues/1643)

build-an-atom 1.5-phetio (https://github.com/phetsims/scenery/issues/1643)

build-an-atom 1.6 (https://github.com/phetsims/scenery/issues/1643)

calculus-grapher 1.0 (https://github.com/phetsims/scenery/issues/1643)

capacitor-lab-basics 1.6 (https://github.com/phetsims/scenery/issues/1643)

center-and-variability 1.1 (https://github.com/phetsims/scenery/issues/1643)

charges-and-fields 1.0 (https://github.com/phetsims/scenery/issues/1643)

charges-and-fields 1.0-phetio (https://github.com/phetsims/scenery/issues/1643)

circuit-construction-kit-ac 1.0 (https://github.com/phetsims/scenery/issues/1643)

circuit-construction-kit-ac-virtual-lab 1.0 (https://github.com/phetsims/scenery/issues/1643)

circuit-construction-kit-dc 1.3 (https://github.com/phetsims/scenery/issues/1643)

circuit-construction-kit-dc-virtual-lab 1.3 (https://github.com/phetsims/scenery/issues/1643)

collision-lab 1.1 (https://github.com/phetsims/scenery/issues/1643)

color-vision 1.1 (https://github.com/phetsims/scenery/issues/1643)

color-vision 1.2-phetio (https://github.com/phetsims/scenery/issues/1643)

concentration 1.5-phetio (https://github.com/phetsims/scenery/issues/1643)

concentration 1.7 (https://github.com/phetsims/scenery/issues/1643)

coulombs-law 1.0 (https://github.com/phetsims/scenery/issues/1643)

curve-fitting 1.0 (https://github.com/phetsims/scenery/issues/1643)

density 1.1 (https://github.com/phetsims/scenery/issues/1643)

diffusion 1.0 (https://github.com/phetsims/scenery/issues/1643)

energy-forms-and-changes 1.4 (https://github.com/phetsims/scenery/issues/1643)

energy-skate-park 1.3 (https://github.com/phetsims/scenery/issues/1643)

energy-skate-park-basics 1.1 (https://github.com/phetsims/scenery/issues/1643)

energy-skate-park-basics 1.3-phetio (https://github.com/phetsims/scenery/issues/1643)

equality-explorer 1.1 (https://github.com/phetsims/scenery/issues/1643)

equality-explorer-basics 1.0 (https://github.com/phetsims/scenery/issues/1643)

equality-explorer-two-variables 1.0 (https://github.com/phetsims/scenery/issues/1643)

expression-exchange 1.1 (https://github.com/phetsims/scenery/issues/1643)

faradays-law 1.3-phetio (https://github.com/phetsims/scenery/issues/1643)

faradays-law 1.4 (https://github.com/phetsims/scenery/issues/1643)

forces-and-motion-basics 2.1-phetio (https://github.com/phetsims/scenery/issues/1643)

forces-and-motion-basics 2.3 (https://github.com/phetsims/scenery/issues/1643)

fourier-making-waves 1.0 (https://github.com/phetsims/scenery/issues/1643)

fraction-matcher 1.2 (https://github.com/phetsims/scenery/issues/1643)

fractions-equality 1.1 (https://github.com/phetsims/scenery/issues/1643)

fractions-intro 1.0 (https://github.com/phetsims/scenery/issues/1643)

fractions-mixed-numbers 1.0 (https://github.com/phetsims/scenery/issues/1643)

friction 1.6 (https://github.com/phetsims/scenery/issues/1643)

function-builder 1.2 (https://github.com/phetsims/scenery/issues/1643)

function-builder-basics 1.2 (https://github.com/phetsims/scenery/issues/1643)

gas-properties 1.0 (https://github.com/phetsims/scenery/issues/1643)

gases-intro 1.0 (https://github.com/phetsims/scenery/issues/1643)

gene-expression-essentials 1.0 (https://github.com/phetsims/scenery/issues/1643)

geometric-optics 1.3 (https://github.com/phetsims/scenery/issues/1643)

geometric-optics-basics 1.3 (https://github.com/phetsims/scenery/issues/1643)

graphing-lines 1.4 (https://github.com/phetsims/scenery/issues/1643)

graphing-quadratics 1.3 (https://github.com/phetsims/scenery/issues/1643)

graphing-slope-intercept 1.2 (https://github.com/phetsims/scenery/issues/1643)

gravity-and-orbits 1.5 (https://github.com/phetsims/scenery/issues/1643)

gravity-and-orbits 1.6 (https://github.com/phetsims/scenery/issues/1643)

gravity-force-lab 2.2 (https://github.com/phetsims/scenery/issues/1643)

gravity-force-lab-basics 1.1 (https://github.com/phetsims/scenery/issues/1643)

greenhouse-effect 1.0 (https://github.com/phetsims/scenery/issues/1643)

greenhouse-effect 1.2 (https://github.com/phetsims/scenery/issues/1643)

greenhouse-effect 1.3 (https://github.com/phetsims/scenery/issues/1643)

hookes-law 1.0 (https://github.com/phetsims/scenery/issues/1643)

isotopes-and-atomic-mass 1.1 (https://github.com/phetsims/scenery/issues/1643)

john-travoltage 1.4-phetio (https://github.com/phetsims/scenery/issues/1643)

john-travoltage 1.6 (https://github.com/phetsims/scenery/issues/1643)

keplers-laws 1.2 (https://github.com/phetsims/scenery/issues/1643)

least-squares-regression 1.1 (https://github.com/phetsims/scenery/issues/1643)

make-a-ten 1.0 (https://github.com/phetsims/scenery/issues/1643)

masses-and-springs 1.0 (https://github.com/phetsims/scenery/issues/1643)

masses-and-springs-basics 1.0 (https://github.com/phetsims/scenery/issues/1643)

mean-share-and-balance 1.0 (https://github.com/phetsims/scenery/issues/1643)

molarity 1.4 (https://github.com/phetsims/scenery/issues/1643)

molarity 1.5 (https://github.com/phetsims/scenery/issues/1643)

molecule-polarity 1.3 (https://github.com/phetsims/scenery/issues/1643)

molecule-shapes 1.6 (https://github.com/phetsims/scenery/issues/1643)

molecule-shapes-basics 1.6 (https://github.com/phetsims/scenery/issues/1643)

molecules-and-light 1.3-phetio (https://github.com/phetsims/scenery/issues/1643)

molecules-and-light 1.5 (https://github.com/phetsims/scenery/issues/1643)

my-solar-system 1.3 (https://github.com/phetsims/scenery/issues/1643)

natural-selection 1.2 (https://github.com/phetsims/scenery/issues/1643)

natural-selection 1.3 (https://github.com/phetsims/scenery/issues/1643)

natural-selection 1.4 (https://github.com/phetsims/scenery/issues/1643)

natural-selection 1.5 (https://github.com/phetsims/scenery/issues/1643)

neuron 1.1 (https://github.com/phetsims/scenery/issues/1643)

normal-modes 1.0 (https://github.com/phetsims/scenery/issues/1643)

number-compare 1.0 (https://github.com/phetsims/scenery/issues/1643)

number-line-distance 1.1 (https://github.com/phetsims/scenery/issues/1643)

number-line-integers 1.2 (https://github.com/phetsims/scenery/issues/1643)

number-line-operations 1.1 (https://github.com/phetsims/scenery/issues/1643)

number-play 1.1 (https://github.com/phetsims/scenery/issues/1643)

ohms-law 1.4 (https://github.com/phetsims/scenery/issues/1643)

pendulum-lab 1.0 (https://github.com/phetsims/scenery/issues/1643)

ph-scale 1.6 (https://github.com/phetsims/scenery/issues/1643)

ph-scale-basics 1.5 (https://github.com/phetsims/scenery/issues/1643)

ph-scale-basics 1.6 (https://github.com/phetsims/scenery/issues/1643)

plinko-probability 1.1 (https://github.com/phetsims/scenery/issues/1643)

projectile-data-lab 1.0 (https://github.com/phetsims/scenery/issues/1643)

projectile-motion 1.0 (https://github.com/phetsims/scenery/issues/1643)

projectile-sampling-distributions 1.0 (https://github.com/phetsims/scenery/issues/1643)

proportion-playground 1.0 (https://github.com/phetsims/scenery/issues/1643)

quadrilateral 1.1 (https://github.com/phetsims/scenery/issues/1643)

ratio-and-proportion 1.2 (https://github.com/phetsims/scenery/issues/1643)

reactants-products-and-leftovers 1.2 (https://github.com/phetsims/scenery/issues/1643)

resistance-in-a-wire 1.3-phetio (https://github.com/phetsims/scenery/issues/1643)

resistance-in-a-wire 1.6 (https://github.com/phetsims/scenery/issues/1643)

rutherford-scattering 1.1 (https://github.com/phetsims/scenery/issues/1643)

sound-waves 1.1 (https://github.com/phetsims/scenery/issues/1643)

states-of-matter 1.2 (https://github.com/phetsims/scenery/issues/1643)

states-of-matter-basics 1.2 (https://github.com/phetsims/scenery/issues/1643)

trig-tour 1.0 (https://github.com/phetsims/scenery/issues/1643)

under-pressure 1.1 (https://github.com/phetsims/scenery/issues/1643)

unit-rates 1.0 (https://github.com/phetsims/scenery/issues/1643)

vector-addition 1.0 (https://github.com/phetsims/scenery/issues/1643)

vector-addition-equations 1.0 (https://github.com/phetsims/scenery/issues/1643)

wave-interference 2.0 (https://github.com/phetsims/scenery/issues/1643)

wave-on-a-string 1.1 (https://github.com/phetsims/scenery/issues/1643)

waves-intro 1.1 (https://github.com/phetsims/scenery/issues/1643)

Nancy-Salpepi commented 4 months ago

@jonathanolson in Acid-Base Solutions with Arabic selected, the text for the pH meter is off.

Screenshot 2024-07-10 at 10 41 23 AM
Nancy-Salpepi commented 4 months ago

@jonathanolson for Area Builder adding ?locale=ar to the end of the url causes the sim to still open in English. (The sim has been translated to Arabic because ?locale=ar works on the published version).

jonathanolson commented 4 months ago

List replaced with rc.2s, should have the new workaround in place, AND should be deployed with all locales (I believe).

Nancy-Salpepi commented 4 months ago

@jonathanolson are BASE 1.3-phetio and build-an-atom 1.5-phetio too old for the locale query parameter to work?

Also seen with:

jonathanolson commented 4 months ago

I believe if the sim is phet-io only AND has -phetio in the branch, we do not need to test the locale query parameter.

KatieWoe commented 4 months ago

pH Scale Basics 1.5.18 has a bit of an oddity. If you get the standard wrapper from studio, then use ?locale=ar on that wrapper the items in the drop down won't be translated.

KatieWoe commented 4 months ago

QA is done

jonathanolson commented 4 months ago

Thanks, I'm asking about pH Scale Basics 1.5 (which seems like a separate issue), I'll proceed with production deployments.

jonathanolson commented 4 months ago

MR was deployed up on Friday. I fixed the one build failure that was encountered, should all be deployed. Thanks!