phetsims / qa

Quality Assurance Task Tracking
MIT License
13 stars 8 forks source link

Dev Test: iOS app 1.2(27) #218

Closed mattpen closed 5 years ago

mattpen commented 5 years ago

QA, please test the latest version of the app on TestFlight. Please confirm if the issues assigned to @KatieWoe have been fixed or not: https://github.com/phetsims/phet-ios-app/issues/assigned/katiewoe.

@oliver-phet - You should be able to access this version as well if you want to review the latest design implementation.

Assigning @ariel-phet for priority.

KatieWoe commented 5 years ago

List of issues for team and to check off as tested. @mattpen let me know if you see something was missed. Italics can't be tested yet.

oliver-phet commented 5 years ago

There are numerous issues I've seen in (27) so far... filtering isn't working, table/list view don't change the view, filter panel fitting to the device, search/toolbar not hiding on scroll.

KatieWoe commented 5 years ago

I also notice that https://github.com/phetsims/phet-ios-app/issues/339 occurs here as well as in the published version

chris-huxtable commented 5 years ago

I just wanted to note that 1.2(27) is still 'alpha' and not feature complete.

Most things in the filter/search area are not complete. I think everything else should be 'beta' status though.

KatieWoe commented 5 years ago

@chris-huxtable I just noticed something, and I'm not sure if it will be fixed when filters are implemented. I'm putting a description here, and will make an issue if you think it is needed. Right now a filter can be added by looking at the info for a sim and selecting one of the subject tags. However, it is not then possible to go back to all the sims.

chris-huxtable commented 5 years ago

This is already fixed in the feature/tabBar branch and will be included in the next test flight build.

KatieWoe commented 5 years ago

@chris-huxtable I believe that addresses the issues that we needed to check with (27). I'm keeping this open to look for new bugs. Are there any issues that you wanted looked at that were missed or that you want more info/clarification on?

chris-huxtable commented 5 years ago

I think you have addressed everything. There should be a new version up tomorrow that finally puts a nail in the filters system.

mattpen commented 5 years ago

I've published 1.2(29), should this issue be closed?

KatieWoe commented 5 years ago

I think testing can continue on this issue unless you would like to keep them separate.

KatieWoe commented 5 years ago

Never mind, just saw the new issue. Yes this can be closed.

mattpen commented 5 years ago

New issue for build 29: #223