Closed jonathanolson closed 5 years ago
I'm going to test some of these on my Windows today, and do all of them on my phone tomorrow/while at the conference. To QA workers, please test these on Safari on the beta Mac OS device and on Hopper once Oliver has updated it to iPad OS.
Some seem to be fixed and others aren't. I'm on iOS 13.1 on iPhone and will list which sims seem broken here: Acid Base Solutions Area Builder Arithmetic Atomic Interactions Balancing Act Beer's Law Lab Bending Light Build an Atom Charges and Fields Color Vision Concentration Energy skate park basics Expression Exchange Faradays Law Forces and Motion Basics Fraction Matcher Function Builder Function Builder Basics Gene Expression Essentials Gravity and Orbits Gravity Force Lab Hookes Law John Travoltage Least Squares Regression Make a Ten Molecule Polarity Neuron Pendulum Lab Plinko Probability Projectile Motion Proportion playground Trig Tour Under Pressure Unit Rates Wave on a String
I created a test matrix. Anyone should be able to edit. Feel free to add or subtract platforms, @KatieWoe.
@KatieWoe, I'm going to add your list to the test matrix.
I'm patching phet-core, since some older sims didn't have the safari detection code (so the patch wouldn't have affected them). I'll have another list for testing as soon as I can.
Here's an updated list with the patches:
acid-base-solutions 1.2 (https://github.com/phetsims/sun/issues/526)
area-builder 1.1 (https://github.com/phetsims/sun/issues/526)
area-model-algebra 1.0 (https://github.com/phetsims/sun/issues/526)
area-model-decimals 1.0 (https://github.com/phetsims/sun/issues/526)
area-model-introduction 1.0 (https://github.com/phetsims/sun/issues/526)
area-model-multiplication 1.0 (https://github.com/phetsims/sun/issues/526)
arithmetic 1.0 (https://github.com/phetsims/sun/issues/526)
atomic-interactions 1.0 (https://github.com/phetsims/sun/issues/526)
balancing-act 1.1 (https://github.com/phetsims/sun/issues/526)
balancing-chemical-equations 1.2 (https://github.com/phetsims/sun/issues/526)
balloons-and-static-electricity 1.3-phetio (https://github.com/phetsims/sun/issues/526)
balloons-and-static-electricity 1.4 (https://github.com/phetsims/sun/issues/526)
beers-law-lab 1.4 (https://github.com/phetsims/sun/issues/526)
beers-law-lab 1.5-phetio (https://github.com/phetsims/sun/issues/526)
beers-law-lab 1.6-phetio (https://github.com/phetsims/sun/issues/526)
bending-light 1.1 (https://github.com/phetsims/sun/issues/526)
blackbody-spectrum 1.0 (https://github.com/phetsims/sun/issues/526)
build-a-fraction 1.0 (https://github.com/phetsims/sun/issues/526)
build-an-atom 1.4-phetio (https://github.com/phetsims/sun/issues/526)
build-an-atom 1.5-phetio (https://github.com/phetsims/sun/issues/526)
build-an-atom 1.6 (https://github.com/phetsims/sun/issues/526)
capacitor-lab-basics 1.3-phetio (https://github.com/phetsims/sun/issues/526)
capacitor-lab-basics 1.6 (https://github.com/phetsims/sun/issues/526)
charges-and-fields 1.0 (https://github.com/phetsims/sun/issues/526)
charges-and-fields 1.0-phetio (https://github.com/phetsims/sun/issues/526)
circuit-construction-kit-black-box-study 1.1-phetio (https://github.com/phetsims/sun/issues/526)
circuit-construction-kit-dc 1.1 (https://github.com/phetsims/sun/issues/526)
circuit-construction-kit-dc-virtual-lab 1.1 (https://github.com/phetsims/sun/issues/526)
color-vision 1.1 (https://github.com/phetsims/sun/issues/526)
color-vision 1.2-phetio (https://github.com/phetsims/sun/issues/526)
concentration 1.3 (https://github.com/phetsims/sun/issues/526)
concentration 1.5-phetio (https://github.com/phetsims/sun/issues/526)
coulombs-law 1.0 (https://github.com/phetsims/sun/issues/526)
diffusion 1.0 (https://github.com/phetsims/sun/issues/526)
energy-forms-and-changes 1.0 (https://github.com/phetsims/sun/issues/526)
energy-skate-park-basics 1.1 (https://github.com/phetsims/sun/issues/526)
energy-skate-park-basics 1.3-phetio (https://github.com/phetsims/sun/issues/526)
equality-explorer 1.0 (https://github.com/phetsims/sun/issues/526)
equality-explorer-basics 1.0 (https://github.com/phetsims/sun/issues/526)
equality-explorer-two-variables 1.0 (https://github.com/phetsims/sun/issues/526)
expression-exchange 1.1 (https://github.com/phetsims/sun/issues/526)
faradays-law 1.1 (https://github.com/phetsims/sun/issues/526)
faradays-law 1.3-phetio (https://github.com/phetsims/sun/issues/526)
forces-and-motion-basics 2.1-phetio (https://github.com/phetsims/sun/issues/526)
forces-and-motion-basics 2.3 (https://github.com/phetsims/sun/issues/526)
fraction-matcher 1.1 (https://github.com/phetsims/sun/issues/526)
fractions-equality 1.0 (https://github.com/phetsims/sun/issues/526)
fractions-intro 1.0 (https://github.com/phetsims/sun/issues/526)
fractions-mixed-numbers 1.0 (https://github.com/phetsims/sun/issues/526)
friction 1.5 (https://github.com/phetsims/sun/issues/526)
function-builder 1.0 (https://github.com/phetsims/sun/issues/526)
function-builder-basics 1.0 (https://github.com/phetsims/sun/issues/526)
gas-properties 1.0 (https://github.com/phetsims/sun/issues/526)
gases-intro 1.0 (https://github.com/phetsims/sun/issues/526)
gene-expression-essentials 1.0 (https://github.com/phetsims/sun/issues/526)
graphing-lines 1.3 (https://github.com/phetsims/sun/issues/526)
graphing-quadratics 1.1 (https://github.com/phetsims/sun/issues/526)
graphing-slope-intercept 1.1 (https://github.com/phetsims/sun/issues/526)
gravity-and-orbits 1.1 (https://github.com/phetsims/sun/issues/526)
gravity-force-lab 2.1 (https://github.com/phetsims/sun/issues/526)
hookes-law 1.0 (https://github.com/phetsims/sun/issues/526)
isotopes-and-atomic-mass 1.1 (https://github.com/phetsims/sun/issues/526)
john-travoltage 1.4-phetio (https://github.com/phetsims/sun/issues/526)
john-travoltage 1.5 (https://github.com/phetsims/sun/issues/526)
least-squares-regression 1.1 (https://github.com/phetsims/sun/issues/526)
make-a-ten 1.0 (https://github.com/phetsims/sun/issues/526)
masses-and-springs 1.0 (https://github.com/phetsims/sun/issues/526)
masses-and-springs-basics 1.0 (https://github.com/phetsims/sun/issues/526)
molarity 1.4 (https://github.com/phetsims/sun/issues/526)
molecule-polarity 1.0 (https://github.com/phetsims/sun/issues/526)
molecule-shapes 1.2 (https://github.com/phetsims/sun/issues/526)
molecule-shapes-basics 1.2 (https://github.com/phetsims/sun/issues/526)
molecules-and-light 1.3-phetio (https://github.com/phetsims/sun/issues/526)
molecules-and-light 1.4 (https://github.com/phetsims/sun/issues/526)
neuron 1.1 (https://github.com/phetsims/sun/issues/526)
ohms-law 1.4 (https://github.com/phetsims/sun/issues/526)
pendulum-lab 1.0 (https://github.com/phetsims/sun/issues/526)
ph-scale 1.3 (https://github.com/phetsims/sun/issues/526)
ph-scale-basics 1.3 (https://github.com/phetsims/sun/issues/526)
phet-io-test-sim 1.0 (https://github.com/phetsims/sun/issues/526)
phet-io-test-sim 1.1 (https://github.com/phetsims/sun/issues/526)
phet-io-test-sim 1.2 (https://github.com/phetsims/sun/issues/526)
phet-io-test-sim 1.3 (https://github.com/phetsims/sun/issues/526)
plinko-probability 1.1 (https://github.com/phetsims/sun/issues/526)
projectile-motion 1.0 (https://github.com/phetsims/sun/issues/526)
proportion-playground 1.0 (https://github.com/phetsims/sun/issues/526)
reactants-products-and-leftovers 1.2 (https://github.com/phetsims/sun/issues/526)
resistance-in-a-wire 1.6 (https://github.com/phetsims/sun/issues/526)
states-of-matter 1.1 (https://github.com/phetsims/sun/issues/526)
states-of-matter-basics 1.1 (https://github.com/phetsims/sun/issues/526)
trig-tour 1.0 (https://github.com/phetsims/sun/issues/526)
under-pressure 1.1 (https://github.com/phetsims/sun/issues/526)
unit-rates 1.0 (https://github.com/phetsims/sun/issues/526)
wave-interference 1.0 (https://github.com/phetsims/sun/issues/526)
wave-on-a-string 1.1 (https://github.com/phetsims/sun/issues/526)
Resetting the test matrix for the new list of sims.
iPadOS 13 App has the same problem as Rutherford Scattering in that it does not work there despite seeming to be solved in safari @mattpen @jonathanolson
QA is done. Everything but iPadOS App looks fixed.
Sounds good, I'm going to kick off the deployment.
Links that should have been deployed, I'm going to test them to make sure deployments completed.
acid-base-solutions 1.2 ()
area-builder 1.1 ()
area-model-algebra 1.0 ()
area-model-decimals 1.0 ()
area-model-introduction 1.0 ()
area-model-multiplication 1.0 ()
arithmetic 1.0 ()
atomic-interactions 1.0 ()
balancing-act 1.1 ()
balancing-chemical-equations 1.2 ()
balloons-and-static-electricity 1.3-phetio ()
balloons-and-static-electricity 1.4 ()
beers-law-lab 1.4 ()
beers-law-lab 1.5-phetio ()
beers-law-lab 1.6-phetio ()
bending-light 1.1 ()
blackbody-spectrum 1.0 ()
build-a-fraction 1.0 ()
build-an-atom 1.4-phetio ()
build-an-atom 1.5-phetio ()
build-an-atom 1.6 ()
capacitor-lab-basics 1.3-phetio ()
capacitor-lab-basics 1.6 ()
charges-and-fields 1.0 ()
charges-and-fields 1.0-phetio ()
circuit-construction-kit-black-box-study 1.1-phetio ()
circuit-construction-kit-dc 1.1 ()
circuit-construction-kit-dc-virtual-lab 1.1 ()
color-vision 1.1 ()
color-vision 1.2-phetio ()
concentration 1.3 ()
concentration 1.5-phetio ()
coulombs-law 1.0 ()
diffusion 1.0 ()
energy-forms-and-changes 1.0 ()
energy-skate-park-basics 1.1 ()
energy-skate-park-basics 1.3-phetio ()
equality-explorer 1.0 ()
equality-explorer-basics 1.0 ()
equality-explorer-two-variables 1.0 ()
expression-exchange 1.1 ()
faradays-law 1.1 ()
faradays-law 1.3-phetio ()
forces-and-motion-basics 2.1-phetio ()
forces-and-motion-basics 2.3 ()
fraction-matcher 1.1 ()
fractions-equality 1.0 ()
fractions-intro 1.0 ()
fractions-mixed-numbers 1.0 ()
friction 1.5 ()
function-builder 1.0 ()
function-builder-basics 1.0 ()
gas-properties 1.0 ()
gases-intro 1.0 ()
gene-expression-essentials 1.0 ()
graphing-lines 1.3 ()
graphing-quadratics 1.1 ()
graphing-slope-intercept 1.1 ()
gravity-and-orbits 1.1 ()
gravity-force-lab 2.1 ()
hookes-law 1.0 ()
isotopes-and-atomic-mass 1.1 ()
john-travoltage 1.4-phetio ()
john-travoltage 1.5 ()
least-squares-regression 1.1 ()
make-a-ten 1.0 ()
masses-and-springs 1.0 ()
masses-and-springs-basics 1.0 ()
molarity 1.4 ()
molecule-polarity 1.0 ()
molecule-shapes 1.2 ()
molecule-shapes-basics 1.2 ()
molecules-and-light 1.3-phetio ()
molecules-and-light 1.4 ()
neuron 1.1 ()
ohms-law 1.4 ()
pendulum-lab 1.0 ()
ph-scale 1.3 ()
ph-scale-basics 1.3 ()
phet-io-test-sim 1.0 ()
phet-io-test-sim 1.1 ()
phet-io-test-sim 1.2 ()
phet-io-test-sim 1.3 ()
plinko-probability 1.1 ()
projectile-motion 1.0 ()
proportion-playground 1.0 ()
reactants-products-and-leftovers 1.2 ()
resistance-in-a-wire 1.6 ()
states-of-matter 1.1 ()
states-of-matter-basics 1.1 ()
trig-tour 1.0 ()
under-pressure 1.1 ()
unit-rates 1.0 ()
wave-interference 1.0 ()
wave-on-a-string 1.1 ()
Links above look good.
@KatieWoe should we check the iPad app now, after refreshing to new versions, to see if it is buggy in sims other than rutherford-scattering?
We can, but I think it will be since we checked on the "debug" version of the app, and it seemed like the fix didn't take there.
Ok, thanks! I'll leave that as investigation in the original issue, and close here.
This should aim to work around https://github.com/phetsims/sun/issues/526, and will apply the workaround to Safari for all radial gradients with different start/end points.
This is most notable on iOS 13, where pressing a reset-all button causes the main body of it to disappear.
Can we have brief testing (5-15 seconds each sim, make sure it isn't horribly broken), and also confirm that reset-all buttons, when pressed on Safari platforms look correct? Any other sim gradients, particularly circular buttons should also be correct. I'd use your judgment about what platforms to test, but at least some testing should be done on desktop Safari, iPadOS 13, a non-Safari browser, and possibly iOS 13. @ariel-phet thoughts?
acid-base-solutions 1.2 (https://github.com/phetsims/sun/issues/526)
area-builder 1.1 (https://github.com/phetsims/sun/issues/526)
area-model-algebra 1.0 (https://github.com/phetsims/sun/issues/526)
area-model-decimals 1.0 (https://github.com/phetsims/sun/issues/526)
area-model-introduction 1.0 (https://github.com/phetsims/sun/issues/526)
area-model-multiplication 1.0 (https://github.com/phetsims/sun/issues/526)
arithmetic 1.0 (https://github.com/phetsims/sun/issues/526)
atomic-interactions 1.0 (https://github.com/phetsims/sun/issues/526)
balancing-act 1.1 (https://github.com/phetsims/sun/issues/526)
balancing-chemical-equations 1.2 (https://github.com/phetsims/sun/issues/526)
balloons-and-static-electricity 1.3-phetio (https://github.com/phetsims/sun/issues/526)
balloons-and-static-electricity 1.4 (https://github.com/phetsims/sun/issues/526)
beers-law-lab 1.4 (https://github.com/phetsims/sun/issues/526)
beers-law-lab 1.5-phetio (https://github.com/phetsims/sun/issues/526)
beers-law-lab 1.6-phetio (https://github.com/phetsims/sun/issues/526)
bending-light 1.1 (https://github.com/phetsims/sun/issues/526)
blackbody-spectrum 1.0 (https://github.com/phetsims/sun/issues/526)
build-a-fraction 1.0 (https://github.com/phetsims/sun/issues/526)
build-an-atom 1.4-phetio (https://github.com/phetsims/sun/issues/526)
build-an-atom 1.5-phetio (https://github.com/phetsims/sun/issues/526)
build-an-atom 1.6 (https://github.com/phetsims/sun/issues/526)
capacitor-lab-basics 1.3-phetio (https://github.com/phetsims/sun/issues/526)
capacitor-lab-basics 1.6 (https://github.com/phetsims/sun/issues/526)
charges-and-fields 1.0 (https://github.com/phetsims/sun/issues/526)
charges-and-fields 1.0-phetio (https://github.com/phetsims/sun/issues/526)
circuit-construction-kit-black-box-study 1.1-phetio (https://github.com/phetsims/sun/issues/526)
circuit-construction-kit-dc 1.1 (https://github.com/phetsims/sun/issues/526)
circuit-construction-kit-dc-virtual-lab 1.1 (https://github.com/phetsims/sun/issues/526)
color-vision 1.1 (https://github.com/phetsims/sun/issues/526)
color-vision 1.2-phetio (https://github.com/phetsims/sun/issues/526)
concentration 1.3 (https://github.com/phetsims/sun/issues/526)
concentration 1.5-phetio (https://github.com/phetsims/sun/issues/526)
coulombs-law 1.0 (https://github.com/phetsims/sun/issues/526)
diffusion 1.0 (https://github.com/phetsims/sun/issues/526)
energy-forms-and-changes 1.0 (https://github.com/phetsims/sun/issues/526)
energy-skate-park-basics 1.1 (https://github.com/phetsims/sun/issues/526)
energy-skate-park-basics 1.3-phetio (https://github.com/phetsims/sun/issues/526)
equality-explorer 1.0 (https://github.com/phetsims/sun/issues/526)
equality-explorer-basics 1.0 (https://github.com/phetsims/sun/issues/526)
equality-explorer-two-variables 1.0 (https://github.com/phetsims/sun/issues/526)
expression-exchange 1.1 (https://github.com/phetsims/sun/issues/526)
faradays-law 1.1 (https://github.com/phetsims/sun/issues/526)
faradays-law 1.3-phetio (https://github.com/phetsims/sun/issues/526)
forces-and-motion-basics 2.1-phetio (https://github.com/phetsims/sun/issues/526)
forces-and-motion-basics 2.3 (https://github.com/phetsims/sun/issues/526)
fraction-matcher 1.1 (https://github.com/phetsims/sun/issues/526)
fractions-equality 1.0 (https://github.com/phetsims/sun/issues/526)
fractions-intro 1.0 (https://github.com/phetsims/sun/issues/526)
fractions-mixed-numbers 1.0 (https://github.com/phetsims/sun/issues/526)
friction 1.5 (https://github.com/phetsims/sun/issues/526)
function-builder 1.0 (https://github.com/phetsims/sun/issues/526)
function-builder-basics 1.0 (https://github.com/phetsims/sun/issues/526)
gas-properties 1.0 (https://github.com/phetsims/sun/issues/526)
gases-intro 1.0 (https://github.com/phetsims/sun/issues/526)
gene-expression-essentials 1.0 (https://github.com/phetsims/sun/issues/526)
graphing-lines 1.3 (https://github.com/phetsims/sun/issues/526)
graphing-quadratics 1.1 (https://github.com/phetsims/sun/issues/526)
graphing-slope-intercept 1.1 (https://github.com/phetsims/sun/issues/526)
gravity-and-orbits 1.1 (https://github.com/phetsims/sun/issues/526)
gravity-force-lab 2.1 (https://github.com/phetsims/sun/issues/526)
hookes-law 1.0 (https://github.com/phetsims/sun/issues/526)
isotopes-and-atomic-mass 1.1 (https://github.com/phetsims/sun/issues/526)
john-travoltage 1.4-phetio (https://github.com/phetsims/sun/issues/526)
john-travoltage 1.5 (https://github.com/phetsims/sun/issues/526)
least-squares-regression 1.1 (https://github.com/phetsims/sun/issues/526)
make-a-ten 1.0 (https://github.com/phetsims/sun/issues/526)
masses-and-springs 1.0 (https://github.com/phetsims/sun/issues/526)
masses-and-springs-basics 1.0 (https://github.com/phetsims/sun/issues/526)
molarity 1.4 (https://github.com/phetsims/sun/issues/526)
molecule-polarity 1.0 (https://github.com/phetsims/sun/issues/526)
molecule-shapes 1.2 (https://github.com/phetsims/sun/issues/526)
molecule-shapes-basics 1.2 (https://github.com/phetsims/sun/issues/526)
molecules-and-light 1.3-phetio (https://github.com/phetsims/sun/issues/526)
molecules-and-light 1.4 (https://github.com/phetsims/sun/issues/526)
neuron 1.1 (https://github.com/phetsims/sun/issues/526)
ohms-law 1.4 (https://github.com/phetsims/sun/issues/526)
pendulum-lab 1.0 (https://github.com/phetsims/sun/issues/526)
ph-scale 1.3 (https://github.com/phetsims/sun/issues/526)
ph-scale-basics 1.3 (https://github.com/phetsims/sun/issues/526)
phet-io-test-sim 1.0 (https://github.com/phetsims/sun/issues/526)
phet-io-test-sim 1.1 (https://github.com/phetsims/sun/issues/526)
phet-io-test-sim 1.2 (https://github.com/phetsims/sun/issues/526)
phet-io-test-sim 1.3 (https://github.com/phetsims/sun/issues/526)
plinko-probability 1.1 (https://github.com/phetsims/sun/issues/526)
projectile-motion 1.0 (https://github.com/phetsims/sun/issues/526)
proportion-playground 1.0 (https://github.com/phetsims/sun/issues/526)
reactants-products-and-leftovers 1.2 (https://github.com/phetsims/sun/issues/526)
resistance-in-a-wire 1.6 (https://github.com/phetsims/sun/issues/526)
states-of-matter 1.1 (https://github.com/phetsims/sun/issues/526)
states-of-matter-basics 1.1 (https://github.com/phetsims/sun/issues/526)
trig-tour 1.0 (https://github.com/phetsims/sun/issues/526)
under-pressure 1.1 (https://github.com/phetsims/sun/issues/526)
unit-rates 1.0 (https://github.com/phetsims/sun/issues/526)
wave-interference 1.0 (https://github.com/phetsims/sun/issues/526)
wave-on-a-string 1.1 (https://github.com/phetsims/sun/issues/526)