Maintenance testing for ?allowLinks and fixes

jonathanolson commented 1 year ago

The main functional change is NOT opening links with ?allowLinks=false. Screenshots should still work. Things are currently NOT made invisible, so please reassign to me if certain items should be made invisible with allowLinks=false.

The secondary change is the scenery workaround for https://github.com/phetsims/gravity-and-orbits/issues/472 (which might help some sims artifacts).

Can each sim be checked with the following:

Open the sim normally (Chrome desktop), do a brief (20-30 seconds?) check of the simulation to make sure its major parts function well, and don't show graphical artifacts. Specifically, check paths and line segments.
Open the sim with Safari (desktop), and do a similar test. Artifacts might be there (https://github.com/phetsims/gravity-and-orbits/issues/472), but normal paths and lines should look correct underneath.
Open the sim normally, and verify that (if they exist) all of these actions open in a new window:
- PhET menu => PhET Website...
- PhET menu => Report a Problem...
- PhET menu => About... => "Third party credits" link
- PhET menu => Screenshot (should open a screenshot)
Open the sim with ?allowLinks=false, and verify that (if they exist) all of these actions do nothing:
- PhET menu => PhET Website...
- PhET menu => Report a Problem...
- PhET menu => About... => "Third party credits" link
- ALSO: Make sure that the PhET menu => Screenshot works normally as above (should open a screenshot)

acid-base-solutions 1.2 (https://github.com/phetsims/joist/issues/830)

[x] acid-base-solutions 1.2.28-rc.1

area-builder 1.1 (https://github.com/phetsims/joist/issues/830)

[x] area-builder 1.1.23-rc.1

area-model-algebra 1.2 (https://github.com/phetsims/joist/issues/830)

[x] area-model-algebra 1.2.4-rc.1

area-model-decimals 1.2 (https://github.com/phetsims/joist/issues/830)

[x] area-model-decimals 1.2.4-rc.1

area-model-introduction 1.2 (https://github.com/phetsims/joist/issues/830)

[x] area-model-introduction 1.2.4-rc.1

area-model-multiplication 1.2 (https://github.com/phetsims/joist/issues/830)

[x] area-model-multiplication 1.2.4-rc.1

arithmetic 1.0 (https://github.com/phetsims/joist/issues/830)

[x] arithmetic 1.0.28-rc.1

atomic-interactions 1.2 (https://github.com/phetsims/joist/issues/830)

[x] atomic-interactions 1.2.5-rc.1

balancing-act 1.1 (https://github.com/phetsims/joist/issues/830)

[x] balancing-act 1.1.28-rc.1

balancing-act 1.2 (https://github.com/phetsims/joist/issues/830)

balancing-chemical-equations 1.2 (https://github.com/phetsims/joist/issues/830)

[x] balancing-chemical-equations 1.2.13-rc.1

balloons-and-static-electricity 1.3-phetio (https://github.com/phetsims/joist/issues/830)

balloons-and-static-electricity 1.5 (https://github.com/phetsims/joist/issues/830)

[x] balloons-and-static-electricity 1.5.3-rc.1

beers-law-lab 1.4 (https://github.com/phetsims/joist/issues/830)

[x] beers-law-lab 1.4.21-rc.1

beers-law-lab 1.6-phetio (https://github.com/phetsims/joist/issues/830)

bending-light 1.1 (https://github.com/phetsims/joist/issues/830)

[x] bending-light 1.1.23-rc.1

blackbody-spectrum 1.0 (https://github.com/phetsims/joist/issues/830)

[x] blackbody-spectrum 1.0.10-rc.1

build-a-fraction 1.0 (https://github.com/phetsims/joist/issues/830)

[x] build-a-fraction 1.0.15-rc.1

build-a-molecule 1.0 (https://github.com/phetsims/joist/issues/830)

[x] build-a-molecule 1.0.7-rc.1

build-an-atom 1.5-phetio (https://github.com/phetsims/joist/issues/830)

build-an-atom 1.6 (https://github.com/phetsims/joist/issues/830)

[x] build-an-atom 1.6.18-rc.1

capacitor-lab-basics 1.6 (https://github.com/phetsims/joist/issues/830)

charges-and-fields 1.0 (https://github.com/phetsims/joist/issues/830)

[x] charges-and-fields 1.0.51-rc.1

charges-and-fields 1.0-phetio (https://github.com/phetsims/joist/issues/830)

circuit-construction-kit-ac 1.0 (https://github.com/phetsims/joist/issues/830)

[x] circuit-construction-kit-ac 1.0.3-rc.1

circuit-construction-kit-ac-virtual-lab 1.0 (https://github.com/phetsims/joist/issues/830)

[x] circuit-construction-kit-ac-virtual-lab 1.0.2-rc.1

circuit-construction-kit-black-box-study 1.1-phetio (https://github.com/phetsims/joist/issues/830)

circuit-construction-kit-dc 1.2 (https://github.com/phetsims/joist/issues/830)

[x] circuit-construction-kit-dc 1.2.8-rc.1

circuit-construction-kit-dc-virtual-lab 1.2 (https://github.com/phetsims/joist/issues/830)

[x] circuit-construction-kit-dc-virtual-lab 1.2.8-rc.1

collision-lab 1.1 (https://github.com/phetsims/joist/issues/830)

[x] collision-lab 1.1.6-rc.1

color-vision 1.1 (https://github.com/phetsims/joist/issues/830)

[x] color-vision 1.1.28-rc.1

color-vision 1.2-phetio (https://github.com/phetsims/joist/issues/830)

concentration 1.3 (https://github.com/phetsims/joist/issues/830)

[x] concentration 1.3.23-rc.1

concentration 1.5-phetio (https://github.com/phetsims/joist/issues/830)

coulombs-law 1.0 (https://github.com/phetsims/joist/issues/830)

[x] coulombs-law 1.0.13-rc.1

curve-fitting 1.0 (https://github.com/phetsims/joist/issues/830)

[x] curve-fitting 1.0.3-rc.1

density 1.0 (https://github.com/phetsims/joist/issues/830)

diffusion 1.0 (https://github.com/phetsims/joist/issues/830)

[x] diffusion 1.0.7-rc.1

energy-forms-and-changes 1.4 (https://github.com/phetsims/joist/issues/830)

energy-skate-park 1.1 (https://github.com/phetsims/joist/issues/830)

[x] energy-skate-park 1.1.6-rc.1

energy-skate-park-basics 1.1 (https://github.com/phetsims/joist/issues/830)

[x] energy-skate-park-basics 1.1.22-rc.1

energy-skate-park-basics 1.3-phetio (https://github.com/phetsims/joist/issues/830)

equality-explorer 1.1 (https://github.com/phetsims/joist/issues/830)

[x] equality-explorer 1.1.2-rc.1

equality-explorer-basics 1.0 (https://github.com/phetsims/joist/issues/830)

[x] equality-explorer-basics 1.0.15-rc.1

equality-explorer-two-variables 1.0 (https://github.com/phetsims/joist/issues/830)

[x] equality-explorer-two-variables 1.0.15-rc.1

expression-exchange 1.1 (https://github.com/phetsims/joist/issues/830)

[x] expression-exchange 1.1.17-rc.1

faradays-law 1.3-phetio (https://github.com/phetsims/joist/issues/830)

faradays-law 1.4 (https://github.com/phetsims/joist/issues/830)

[x] faradays-law 1.4.7-rc.1

forces-and-motion-basics 2.1-phetio (https://github.com/phetsims/joist/issues/830)

forces-and-motion-basics 2.3 (https://github.com/phetsims/joist/issues/830)

[x] forces-and-motion-basics 2.3.21-rc.1

fourier-making-waves 1.0 (https://github.com/phetsims/joist/issues/830)

[x] fourier-making-waves 1.0.5-rc.1

fraction-matcher 1.2 (https://github.com/phetsims/joist/issues/830)

[x] fraction-matcher 1.2.4-rc.1

fractions-equality 1.1 (https://github.com/phetsims/joist/issues/830)

[x] fractions-equality 1.1.4-rc.1

fractions-intro 1.0 (https://github.com/phetsims/joist/issues/830)

[x] fractions-intro 1.0.15-rc.1

fractions-mixed-numbers 1.0 (https://github.com/phetsims/joist/issues/830)

[x] fractions-mixed-numbers 1.0.15-rc.1

friction 1.5 (https://github.com/phetsims/joist/issues/830)

[x] friction 1.5.14-rc.1

function-builder 1.2 (https://github.com/phetsims/joist/issues/830)

[x] function-builder 1.2.1-rc.1

function-builder-basics 1.2 (https://github.com/phetsims/joist/issues/830)

[x] function-builder-basics 1.2.1-rc.1

gas-properties 1.0 (https://github.com/phetsims/joist/issues/830)

[x] gas-properties 1.0.7-rc.1

gases-intro 1.0 (https://github.com/phetsims/joist/issues/830)

[x] gases-intro 1.0.8-rc.1

gene-expression-essentials 1.0 (https://github.com/phetsims/joist/issues/830)

[x] gene-expression-essentials 1.0.19-rc.1

geometric-optics 1.1 (https://github.com/phetsims/joist/issues/830)

[x] geometric-optics 1.1.2-rc.1

graphing-lines 1.3 (https://github.com/phetsims/joist/issues/830)

[x] graphing-lines 1.3.13-rc.1

graphing-quadratics 1.1 (https://github.com/phetsims/joist/issues/830)

graphing-quadratics 1.2 (https://github.com/phetsims/joist/issues/830)

graphing-slope-intercept 1.1 (https://github.com/phetsims/joist/issues/830)

[x] graphing-slope-intercept 1.1.12-rc.1

gravity-and-orbits 1.4 (https://github.com/phetsims/joist/issues/830)

gravity-and-orbits 1.5 (https://github.com/phetsims/joist/issues/830)

gravity-and-orbits 1.6 (https://github.com/phetsims/joist/issues/830)

gravity-force-lab 2.2 (https://github.com/phetsims/joist/issues/830)

gravity-force-lab-basics 1.1 (https://github.com/phetsims/joist/issues/830)

[x] gravity-force-lab-basics 1.1.4-rc.1

hookes-law 1.0 (https://github.com/phetsims/joist/issues/830)

[x] hookes-law 1.0.27-rc.1

isotopes-and-atomic-mass 1.1 (https://github.com/phetsims/joist/issues/830)

[x] isotopes-and-atomic-mass 1.1.12-rc.1

john-travoltage 1.4-phetio (https://github.com/phetsims/joist/issues/830)

john-travoltage 1.6 (https://github.com/phetsims/joist/issues/830)

[x] john-travoltage 1.6.5-rc.1

least-squares-regression 1.1 (https://github.com/phetsims/joist/issues/830)

[x] least-squares-regression 1.1.23-rc.1

make-a-ten 1.0 (https://github.com/phetsims/joist/issues/830)

[x] make-a-ten 1.0.19-rc.1

masses-and-springs 1.0 (https://github.com/phetsims/joist/issues/830)

[x] masses-and-springs 1.0.13-rc.1

masses-and-springs-basics 1.0 (https://github.com/phetsims/joist/issues/830)

[x] masses-and-springs-basics 1.0.12-rc.1

molarity 1.4 (https://github.com/phetsims/joist/issues/830)

molarity 1.5 (https://github.com/phetsims/joist/issues/830)

[x] molarity 1.5.7-rc.1

molecule-polarity 1.2 (https://github.com/phetsims/joist/issues/830)

molecule-shapes 1.2 (https://github.com/phetsims/joist/issues/830)

[x] molecule-shapes 1.2.11-rc.1

molecule-shapes-basics 1.2 (https://github.com/phetsims/joist/issues/830)

[x] molecule-shapes-basics 1.2.11-rc.1

molecules-and-light 1.3-phetio (https://github.com/phetsims/joist/issues/830)

molecules-and-light 1.5 (https://github.com/phetsims/joist/issues/830)

[x] molecules-and-light 1.5.14-rc.1

natural-selection 1.2 (https://github.com/phetsims/joist/issues/830)

natural-selection 1.3 (https://github.com/phetsims/joist/issues/830)

natural-selection 1.4 (https://github.com/phetsims/joist/issues/830)

neuron 1.1 (https://github.com/phetsims/joist/issues/830)

[x] neuron 1.1.21-rc.1

number-line-distance 1.0 (https://github.com/phetsims/joist/issues/830)

[x] number-line-distance 1.0.3-rc.1

number-line-integers 1.1 (https://github.com/phetsims/joist/issues/830)

[x] number-line-integers 1.1.5-rc.1

number-line-operations 1.0 (https://github.com/phetsims/joist/issues/830)

[x] number-line-operations 1.0.6-rc.1

ohms-law 1.4 (https://github.com/phetsims/joist/issues/830)

[x] ohms-law 1.4.13-rc.1

pendulum-lab 1.0 (https://github.com/phetsims/joist/issues/830)

[x] pendulum-lab 1.0.18-rc.1

ph-scale 1.5 (https://github.com/phetsims/joist/issues/830)

ph-scale-basics 1.5 (https://github.com/phetsims/joist/issues/830)

plinko-probability 1.1 (https://github.com/phetsims/joist/issues/830)

[x] plinko-probability 1.1.21-rc.1

projectile-motion 1.0 (https://github.com/phetsims/joist/issues/830)

[x] projectile-motion 1.0.18-rc.1

proportion-playground 1.0 (https://github.com/phetsims/joist/issues/830)

[x] proportion-playground 1.0.18-rc.1

ratio-and-proportion 1.0 (https://github.com/phetsims/joist/issues/830)

[x] ratio-and-proportion 1.0.6-rc.1

reactants-products-and-leftovers 1.2 (https://github.com/phetsims/joist/issues/830)

[x] reactants-products-and-leftovers 1.2.14-rc.1

resistance-in-a-wire 1.3-phetio (https://github.com/phetsims/joist/issues/830)

resistance-in-a-wire 1.6 (https://github.com/phetsims/joist/issues/830)

[x] resistance-in-a-wire 1.6.14-rc.1

rutherford-scattering 1.1 (https://github.com/phetsims/joist/issues/830)

[x] rutherford-scattering 1.1.12-rc.1

states-of-matter 1.2 (https://github.com/phetsims/joist/issues/830)

states-of-matter-basics 1.2 (https://github.com/phetsims/joist/issues/830)

trig-tour 1.0 (https://github.com/phetsims/joist/issues/830)

[x] trig-tour 1.0.26-rc.1

under-pressure 1.1 (https://github.com/phetsims/joist/issues/830)

[x] under-pressure 1.1.21-rc.1

unit-rates 1.0 (https://github.com/phetsims/joist/issues/830)

[x] unit-rates 1.0.20-rc.1

vector-addition 1.0 (https://github.com/phetsims/joist/issues/830)

[x] vector-addition 1.0.4-rc.1

vector-addition-equations 1.0 (https://github.com/phetsims/joist/issues/830)

[x] vector-addition-equations 1.0.4-rc.1

wave-interference 2.0 (https://github.com/phetsims/joist/issues/830)

[x] wave-interference 2.0.6-rc.1

wave-on-a-string 1.1 (https://github.com/phetsims/joist/issues/830)

[x] wave-on-a-string 1.1.25-rc.1

waves-intro 1.1 (https://github.com/phetsims/joist/issues/830)

[x] waves-intro 1.1.7-rc.1

jonathanolson commented 1 year ago

@KatieWoe this is ready for testing. Let me know if there are any questions!

jonathanolson commented 1 year ago

I've made some updates to maintenance code, and I'm going to edit the list to include (and update) release branches for prototypes. It was listing phet-io testing for some, and neglected others.

build-a-nucleus, center-and-variability, geometric-optics-basics, greenhouse-effect, mean-share-and-balance, normal-modes, and number-play should be the affected sims.

jonathanolson commented 1 year ago

Additional tests (I'll remove the entries above that are duplicated):

build-a-nucleus 1.0 (https://github.com/phetsims/joist/issues/830)

[x] build-a-nucleus 1.0.3-rc.1

center-and-variability 1.0 (https://github.com/phetsims/joist/issues/830)

geometric-optics-basics 1.2 (https://github.com/phetsims/joist/issues/830)

[x] geometric-optics-basics 1.2.1-rc.1

greenhouse-effect 1.0 (https://github.com/phetsims/joist/issues/830)

mean-share-and-balance 1.0 (https://github.com/phetsims/joist/issues/830)

[x] mean-share-and-balance 1.0.1-rc.1

normal-modes 1.0 (https://github.com/phetsims/joist/issues/830)

[x] normal-modes 1.0.1-rc.1

number-play 1.0 (https://github.com/phetsims/joist/issues/830)

[x] number-play 1.0.5-rc.1

Nancy-Salpepi commented 1 year ago

Saw some artifacts along the red line in Atomic Interactions with Safari. I didn't know if they interfered too much @jonathanolson. See attached video. I also added this sim to top of list in https://github.com/phetsims/scenery/issues/1503

https://user-images.githubusercontent.com/87318828/206250161-465732c1-7450-4765-af30-be862ac801bc.mp4

jonathanolson commented 1 year ago

@Nancy-Salpepi are you able to reproduce in the same manner on the production sim?

Nancy-Salpepi commented 1 year ago

@jonathanolson yes I see it in published as well. I do have to say, it is extremely difficult to notice with the dark background on both versions (which is the default). Also, since I posted the comment, Kathy instructed me to just add sims to the list in the scenery issue. That we are just going to wait for Apple to produce a fix at this point.

KatieWoe commented 1 year ago

Noting that launching in the Instance Proxies doesn't seem to work.

kathy-phet commented 1 year ago

Noting that launching in the Instance Proxies doesn't seem to work.

Katie, Can you be more specific as to which of the sim releases are having this trouble - creating a list of the sim links in one comment as you go. Thanks.

kathy-phet commented 1 year ago

@jonathanolson @Nancy-Salpepi - I do not think any more work on the artifacts is fruitful at this time. We will just have to live with it for the time being, until Apple and Safari get their fixes in. If its still here in 6 months, we may invest more time, but we've invested all the time we have for now.

KatieWoe commented 1 year ago

For more context from Slack: Kathryn Woessner [Today at 9:09 AM] I thought there was an issue for this but I'm not finding it. In the maintenance release, the launch button doesn't seem to work for instance proxies links. I feel like this is known, and not related to this release, but I can't find the documentation. Can anyone help? 2 replies Michael Kauzmann :octopus: [23 minutes ago] I could not find it in 4 minutes of searching. Sorry! Michael Kauzmann :octopus: [22 minutes ago] I don't think it is too big of a deal though. Just a note in the MR about how it doesn't work, and likely nothing else needs doing.

kathy-phet commented 1 year ago

@KatieWoe - Please note that list of instance proxy links where launch doesn't work. Thx.

KatieWoe commented 1 year ago

This was discussed in https://github.com/phetsims/capacitor-lab-basics/issues/291. According to @kathy-phet on Slack it looks like published versions aren't working either. I apologize for missing this.

kathy-phet commented 1 year ago

@KatieWoe - some of them work on phet-io, but not all of them. Let's finish the rest of the QA testing for this maintenance release, when that is done, we will come back to the instance-proxy issue. Thanks!

Nancy-Salpepi commented 1 year ago

@jonathanolson for https://phet-dev.colorado.edu/html/geometric-optics-basics/1.2.1-rc.1/phet/geometric-optics-basics_en_phet.html adding ?allowLinks=false completely removes the PhET Website and Report a Problem options from the PhET Menu. That is different from all the other PhET brand sims I have tested thus far. Is that OK?

kathy-phet commented 1 year ago

Hi Nancy, Yes, that is desired because that is how master behaves now. The maintenance patch for older sims only did the very simplest option of disabling the link itself, not hiding. Going forward for sims freshly built off master recently …eg GAO I think, would have this hide behavior as well. That said, I’m not quite sure what GOB is getting in this maintenance release. Maybe a patch for something else. @jonathanolson?Sent from my iPhoneOn Dec 11, 2022, at 7:46 AM, Nancy Salpepi @.***> wrote: @jonathanolson for https://phet-dev.colorado.edu/html/geometric-optics-basics/1.2.1-rc.1/phet/geometric-optics-basics_en_phet.html adding ?allowLinks=false completely removes the PhET Website and Report a Problem options from the PhET Menu. That is different from all the other PhET brand sims I have tested thus far. Is that OK?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

KatieWoe commented 1 year ago

I'm seeing https://github.com/phetsims/gravity-and-orbits/issues/449 in https://phet-dev.colorado.edu/html/gravity-and-orbits/1.5.4-rc.1/phet-io/gravity-and-orbits_all_phet-io.html?phetioStandalone and https://phet-dev.colorado.edu/html/gravity-and-orbits/1.4.5-rc.1/phet-io/gravity-and-orbits_all_phet-io.html?phetioStandalone, which were before the fix I believe, but I still wanted to comment on it just in case.

KatieWoe commented 1 year ago

QA is done

jonathanolson commented 1 year ago

That said, I’m not quite sure what GOB is getting in this maintenance release. Maybe a patch for something else.

It's getting patched for webpack/puppeteer/chipper compatibility.

It also looks like the release branch was deployed on November 29th (before we had tested this), so I actually won't need to include it in the production deployments.

jonathanolson commented 1 year ago

Thanks! Production deploys completed, closing.

phetsims / qa

Maintenance testing for ?allowLinks and fixes #859