phetsims / quadrilateral

"Quadrilateral" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

Explore new sound design focused on all quadrilateral shape transformations #175

Closed brettfiedler closed 1 year ago

brettfiedler commented 2 years ago

We aim to investigate a new sound design that emphasizes the transition between all named quadrilateral shapes, while supporting their maintenance as well. We aim to capture the build-up of unique properties for named shapes, but not contain the design space so tightly to require exact mapping of properties to sounds. The conceptual space is very complex and does not lend itself well to simple sound design for all relevant conceptual properties.

brettfiedler commented 2 years ago

Talked with EM and Ashton about a possible general sound design that emphasizes the transitions between shapes we name (Convex Quadrilateral, Concave Quadrilateral, Dart, Kite, Trapezoid, Isosceles Trapezoid, Parallelogram, Rhombus, Rectangle, Square) and give the overall impression of building up as you move from shapes with no discernible properties (convex quadrilateral, only requirement = interior angles sum to 360) to shapes with rigid definitions (most complex being square which inherits the definitions of most other quadrilateral shapes).

I attempted to bundle together the unique properties (angles, lengths) about each named quadrilateral to indicate the smallest possible changes as you change between shapes. This resulted in about 7-8 categories as pictures below.

image

  1. Quadrilateral (ambient or silent)
  2. Concave (or inverted)
  3. Diagonal symmetry
  4. Lateral Symmetry
  5. Half-Parallel (1 set of parallel sides)
  6. Full-Parallel (2 sets of parallel sides)
  7. Angle Equality (all = 90)
  8. Side equality (all sides same length)

Categories such as Convex/Concave or Half-Parallel/Full-Parallel can replace each other. Otherwise the sounds are additive.

Likely constraints for any sound designs:

brettfiedler commented 2 years ago

At sound meeting today we talked about introducing further musicality into the sound design during this rapid exploration, including the possible introduction/disappearance of instrumental/rhythmic components.

@Ashton-Morris will begin some mock-ups and follow up with @BLFiedler for synchronous design time and otherwise ping design team members for feedback here/in Slack.

brettfiedler commented 2 years ago

Made by @Ashton-Morris this week:

At a quick meeting between AM and me, we discussed showcasing the possibilities of the following tomorrow using his software:

We'll hold off exporting sounds until after the meeting, but have them ready for when @jessegreenberg can implement.

brettfiedler commented 2 years ago

@Ashton-Morris will export the tracks/loops/tones he has created so far broken out by the sets he demo'd at the last sound meeting. Then @BLFiedler will give specific sound designs for @jessegreenberg to implement in the sim as a priority over other issues (except Voicing issues).

I made these notes on the sets that were demo'd.

Individual notes (chord building for each aspect of shape, e.g., (from https://streamable.com/lqd5qp)) Ambiences (each shape one, ambience may reflect aspect of shape, e.g., https://streamable.com/9q0a07) Tracks: Beat tracks layer with each category addition (building) (e.g., https://streamable.com/mx8i1m) Tracks: Base beat + new track per shape (new track may reflect aspect of shape) Arpeggio: New part of arpeggio per shape (building up) Arpeggio: New part of arpeggio (building up) + new beat track

Tagging other Quad sound design folk for awareness - @emily-phet @terracoda

emily-phet commented 2 years ago

Just a note @BLFiedler: If you feel some of these seem more promising than others, you can go ahead and pick those that seem most promising to move forward with. It's definitely hard to predict exactly how they'll feel before you get to play with them in the sim...but wanted to make sure you knew it's ok to go with your gut to help streamline the process. If your gut says you need to see them all in action, of course, go for it. :)

@Ashton-Morris If any of these don't make it into the sim, can you record a short demo of the idea and list in this thread, so we have a record of it? Since we're trying something totally new here for Quad, we may end up writing about it later and having some examples of early designs will help!

Ashton-Morris commented 2 years ago

In my option we should start with three (time permitting).

@jessegreenberg There should be two types of logic from what I can tell, Shape Identifier, and State Identifier. The sound mockups wen't off of both directions. Hopefully the audio tracks could be interchangeable once that logic is put in. (ex. the logic for the Ambience mockup is the same for the Melody mockup, and the logic for building music is the same for the Arpeggio one.)

Let me know if you have any questions regarding implementation, I'd be happy to walk though things if needed.

Also, I'll do a screen recording of each mockup for our records.

Here are all the files to test.

  1. Individual notes (these are actually lowest in pitch from highest in number to lowest) Quad_Individual_Notes-000.mp3 Quad_Individual_Notes-007.mp3 Quad_Individual_Notes-006.mp3 Quad_Individual_Notes-005.mp3 Quad_Individual_Notes-004.mp3 Quad_Individual_Notes-003.mp3 Quad_Individual_Notes-002.mp3 Quad_Individual_Notes-001.mp3

  2. Ambiences Quad_Ambiences-005.mp3 Quad_Ambiences-001.mp3 Quad_Ambiences-003.mp3 Quad_Ambiences-002.mp3 Quad_Ambiences-004.mp3 Quad_Ambiences-007.mp3 Quad_Ambiences-000.mp3 Quad_Ambiences-006.mp3

  3. Arpeggio: New part of arpeggio Quad_Building_Up_Arpeggio-000.mp3 Quad_Building_Up_Arpeggio-001.mp3 Quad_Building_Up_Arpeggio-002.mp3 Quad_Building_Up_Arpeggio-003.mp3 Quad_Building_Up_Arpeggio-004.mp3 Quad_Building_Up_Arpeggio-005.mp3 Quad_Building_Up_Arpeggio-006.mp3 Quad_Building_Up_Arpeggio-007.mp3

    • Optional Shape Identifier Tracks for above Quad_Building_Up_Arpeggio_Optional_Shape_Identifier_Tracks-000.mp3 Quad_Building_Up_Arpeggio_Optional_Shape_Identifier_Tracks-001.mp3 Quad_Building_Up_Arpeggio_Optional_Shape_Identifier_Tracks-002.mp3 Quad_Building_Up_Arpeggio_Optional_Shape_Identifier_Tracks-003.mp3
  4. Tracks: Beat tracks layer with each category addition (building) Quad_Beat_Tracks_Building_Base_Rhythm.mp3 Quad_Beat_Tracks_Building_Building_Tracks-000.mp3 Quad_Beat_Tracks_Building_Building_Tracks-001.mp3 Quad_Beat_Tracks_Building_Building_Tracks-002.mp3 Quad_Beat_Tracks_Building_Building_Tracks-003.mp3 Quad_Beat_Tracks_Building_Building_Tracks-004.mp3 Quad_Beat_Tracks_Building_Building_Tracks-005.mp3 Quad_Beat_Tracks_Building_Building_Tracks-006.mp3

  5. Melody: Base track plays consistently and each shape has a corresponding melody to it Quad_Melody_Tracks_Base_Music.mp3 Quad_Melody_Tracks_000.mp3 Quad_Melody_Tracks-005.mp3 Quad_Melody_Tracks-004.mp3 Quad_Melody_Tracks-002.mp3 Quad_Melody_Tracks-003.mp3 Quad_Melody_Tracks-001.mp3

jessegreenberg commented 2 years ago

Thanks @Ashton-Morris!

Sorry, I read through the issue but dont understand what to implement. @Ashton-Morris or @BLFiedler can you describe how each of the sound design should work? What sound is associated with what shape or state? How long should each sound play in response to input?

brettfiedler commented 2 years ago

For some quick initial testing let's go with 4 sound sets.

1. Tracks - Build Up.

Here we should try assigning a track to a specific element of the shape that may vary between shapes (e.g., amount of parallel), but builds toward more complex when you reach a square. This is based on my initial comment at the top of the issue.

Ideally, tracks that are already playing continue to play without restarting their loop. Functionally this might involve having all tracks playing all the time, but their volumes muted until they reach a shape that has that track assigned?

First, we assign each file a letter for brevity in the shape assignment

(0) A. Quad_Beat_Tracks_Building_Base_Rhythm.mp3 (base) (1) B. Quad_Beat_Tracks_Building_Building_Tracks-000.mp3 (inversion) (2) C. Quad_Beat_Tracks_Building_Building_Tracks-001.mp3 (diag symmetry) (3) D. Quad_Beat_Tracks_Building_Building_Tracks-002.mp3 (lat symmetry) (4) E. Quad_Beat_Tracks_Building_Building_Tracks-003.mp3 (1 x parallel) (5) F. Quad_Beat_Tracks_Building_Building_Tracks-004.mp3 (2 x parallel) (6) G. Quad_Beat_Tracks_Building_Building_Tracks-005.mp3 (sides equal) (7) H. Quad_Beat_Tracks_Building_Building_Tracks-006.mp3 (angles equal)

Each shape will have one or more tracks playing. Let's assign them like this for now (and adjust later for

(@jessegreenberg, if while implementing you find swapping tracks above makes for better clarity/groovier beats, go for it! They are not mapped to particular elements at the moment. Just assigned based on increasing order).

2. Tracks - Volume Emphasis (Shape/State emphasis)

Here we'll try just giving each shape a part of the whole. Play all tracks all the time, but raise the volume of the assigned track (or lower the volume of all the rest, whichever works). I'm not sure how much to lower or raise, but probably something to quickly feel out during implementation.

We'll use the same letter assignments for the tracks as the previous set.

For the purposes of testing (without explicit mapping) - Let's order the shapes this way and just map on the above-ordered sound files. I realize there are actually 10 shapes and only 8 files for many of these. Let's skip Concave and Dart for now in this one.

3. Melody (Shape/State Emphasis)

Similar to the last set, but instead of changing volume, we'll always play the base rhythm and swap out the tracks for each shape, so there is only ever two tracks playing (base + mapped track).

Again, there are not as many files as shapes here (6 of 10), so we'll have to cut a few for demo purposes.

ALWAYS: Quad_Melody_Tracks_Base_Music.mp3 Concave & Convex: Nothing additional Kite & Dart: Quad_Melody_Tracks_000.mp3 Trapezoid & Isosceles: Quad_Melody_Tracks-005.mp3 Parallelogram: Quad_Melody_Tracks-004.mp3 Rectangle: Quad_Melody_Tracks-002.mp3 Rhombus: Quad_Melody_Tracks-003.mp3 Square: Quad_Melody_Tracks-001.mp3

4. Arpeggio (Hybrid Sequential/Track Shape Emphasis)

Here I believe the goal was to assign both an arpeggio that built up the higher farther into the shape hierarchy you go. I'll be honest that I have difficulty mapping this correctly since there isn't a linear mapping or "logical progression" from Convex to Square. We only have 8 files for 10 shapes that we can detect, so we'll skip Concave/Convex. Also, there are additional tracks to layer, but there are only 4 that I can see. Unless we have more, let's try just differentiating the parallelograms as a test?

Let's try building up from arpeggio files 000 - 007 in the following order:

@jessegreenberg, over to you. Feel free to slack with questions/concerns!

brettfiedler commented 2 years ago

@Ashton-Morris , just to note that there tend to be fewer tracks than shapes for the above sets. I have some alterations above to account for this, but we'll likely want to fill in the gaps before interviews.

jessegreenberg commented 2 years ago

OK everything is implemented with the above commits with the exception of a few sound files in the "Arpeggio" design. I don't see any of the "Quad_Building_Up_Arpeggio_Optional_Shape_Identifier_Tracks" in the google doc file. Once those are in this will be ready for review.

jessegreenberg commented 2 years ago

Since we don't have the "optional arpeggio" sounds we will try playing the melody sounds under the arpeggio, at a reduced volume with this design

Convex (none)
Concave (none)
Dart 000, also play Quad_Melody_Tracks_000.mp3
Kite 000 to 001, also play Quad_Melody_Tracks_000.mp3
Trapezoid 000 to 002, also play Quad_Melody_Tracks-005.mp3
Isosceles Trapezoid 000 to 003, also play Quad_Melody_Tracks-005.mp3
Parallelogram: 000 to 004, also play Quad_Melody_Tracks-004.mp3
Rhombus: 000 to 005, also play Quad_Melody_Tracks-003.mp3
Rectangle: 000 to 006, also play Quad_Melody_Tracks-002.mp3
Square: 000 to 007, also play Quad_Melody_Tracks-001.mp3
jessegreenberg commented 2 years ago

OK, new sound designs are in! @BLFiedler @Ashton-Morris over to you to try it out and consider next steps! https://phet-dev.colorado.edu/html/quadrilateral/1.0.0-dev.46/phet/quadrilateral_en_phet.html

Ashton-Morris commented 2 years ago

@jessegreenberg Sorry I must have missed those. I am adding these now if you still want to add them.

Quad_Building_Up_Arpeggio_Optional_Shape_Identifier_Tracks-000.mp3 Quad_Building_Up_Arpeggio_Optional_Shape_Identifier_Tracks-001.mp3 Quad_Building_Up_Arpeggio_Optional_Shape_Identifier_Tracks-002.mp3 Quad_Building_Up_Arpeggio_Optional_Shape_Identifier_Tracks-003.mp3

brettfiedler commented 2 years ago

From last meeting:

Focus on mapping for

Next Steps:

jessegreenberg commented 2 years ago

The "base" sounds for melody and build-up designs were reduced in the above commits. Removing my assignment.

Ashton-Morris commented 2 years ago

Adding some files for:

Generate base beat track for Build Up and Melody that is reduced in complexity for use in current sound design.

And: Try creating a “simpler” set of tracks for Build Up and Melody.

brettfiedler commented 2 years ago

@jessegreenberg, for quick turnaround to hear these new tracks, if possible before tomorrow (interviews 10AM ET and 3PM ET), let's create three NEW sound design sets:

1.) Tracks - Build Up - Simple Same as Tracks - Build Up, but replace every track with the Simple Version

2.) Tracks - Melody - Simple Same as Tracks - Melody, but replace every track with the Simple Version

3.) Tracks - Melody - Simple Mapping

Combine current Melody with Simple Melody to attain some similarities between similar shapes (similar shapes will have a more or less complex version of the same track).

The next sound designs for Ashton are on Brett to play around with mapping and listening to tracks (though welcome feedback from everyone on that!)

brettfiedler commented 2 years ago

@jessegreenberg Feel free to remove all sound designs from the Preferences Menu list above the Tracks sound designs except for Parallels Volume (though that will probably go soon as well!)

Reverting part of that! @terracoda noted she would need the old Success sound design to match the description for interviews. We will need to retain that one as well.

jessegreenberg commented 2 years ago

@Ashton-Morris @BLFiedler here is a new version with the sounds as they are described in the above comment. Over to you to try it out and comment on next steps. https://phet-dev.colorado.edu/html/quadrilateral/1.0.0-dev.52/phet/quadrilateral_en_phet.html

brettfiedler commented 2 years ago

@jessegreenberg if possible before 2PM ET, thank you!!!

Just update existing Volume Emphasis sound design by adding the simple tracks identified below to Concave and Dart as the emphasized tracks. (still playing all)

(0) A. Quad_Beat_Tracks_Building_Base_Rhythm.mp3 (base) (1) B. Quad_Beat_Tracks_Building_Building_Tracks-000.mp3 (inversion) (2) C. Quad_Beat_Tracks_Building_Building_Tracks-001.mp3 (diag symmetry) (3) D. Quad_Beat_Tracks_Building_Building_Tracks-002.mp3 (lat symmetry) (4) E. Quad_Beat_Tracks_Building_Building_Tracks-003.mp3 (1 x parallel) (5) F. Quad_Beat_Tracks_Building_Building_Tracks-004.mp3 (2 x parallel) (6) G. Quad_Beat_Tracks_Building_Building_Tracks-005.mp3 (sides equal) (7) H. Quad_Beat_Tracks_Building_Building_Tracks-006.mp3 (angles equal)

(8) I. Quad_Base_Beat_Simple.mp3 (9) J. Quad_Simple_Building_Tracks-000.mp3

  • Concave - I
  • Dart - J

Edit with justification I wrote to JG in Slack:

"I'd like to better test the "non-mapped, just distinguishable" sound designs, but I think the Melody sound design isn't triggering the "oh this is different" as currently mixed/mapped, but the volume emphasis should (if it was complete)

We could probably get Melody there, I'm just not sure exactly what changes to make, whereas it's more straightforward with this one!"

jessegreenberg commented 2 years ago

@BLFiedler OK, here is a new version with changes to "Tracks - Volume Emphasis" sound design.

https://phet-dev.colorado.edu/html/quadrilateral/1.0.0-dev.55/phet/quadrilateral_en_phet.html

brettfiedler commented 2 years ago

(discussed w/ JG over Slack, but posting here for posterity)

Trapezoid is kind of hard to hear and Kite/Dart are actually the same since Build Up 000 is the same in simple or normal.

Using a few tracks from the Melody sound design to differentiate can we:

jessegreenberg commented 2 years ago

Sounds good, done in this version: https://phet-dev.colorado.edu/html/quadrilateral/1.0.0-dev.56/phet/quadrilateral_en_phet.html

Ashton-Morris commented 2 years ago
  1. I liked the levels, sound, and feel of: Tracks - Build up - Simple

  2. I felt like: Tracks - Melody - Simple, would have worked better if the melody was less simple. When it's just on 8th note timing as opposed to 16th note timing it misses some instant recognizability. But I did enjoy the backing track bring as low in volume as it was.

  3. Tracks - Melody - Mapping: I am not sure I could hear the distinct mapping on this one as clear. I did enjoy that the backing tracks had some more melodic elements to it but I don't feel like I was perceiving the differences from the previous mapping to this one when it comes to Melody.

brettfiedler commented 2 years ago

I felt like: Tracks - Melody - Simple, would have worked better if the melody was less simple. When it's just on 8th note timing as opposed to 16th note timing it misses some instant recognizability. But I did enjoy the backing track bring as low in volume as it was.

Agreed. And the same goes for the interviews. I think we'll need to do everything we can to boost instant recognizability for each shape transition. Tracks - Volume Emphasis performed better here in that regard. The standout track was sufficiently louder than the "constant" or background pieces.

Tracks - Melody - Mapping: I am not sure I could hear the distinct mapping on this one as clear. I did enjoy that the backing tracks had some more melodic elements to it but I don't feel like I was perceiving the differences from the previous mapping to this one when it comes to Melody.

Yeah, I wasn't sure exactly what was off here, but didn't have time to tease it out. We had enough to go on with the other sound designs.

brettfiedler commented 2 years ago

We're ready to begin modifications here.

After @terracoda finished up the consultant interviews, we chatted and agreed that it might be nicer to continue backing off on the "base" sound used whenever a convex quadrilateral is created/maintained.

I suspect a focus on Tracks - Build Up - Simple design while maintaining the Volume Emphasis design in parallel (no pun intended) would let us continue to provide either a property vs. shape music experience. We do plan to provide more than one sound design in the Preferences menu at publication.

Note, there are only 8 tracks needed for Build Up, but 10 needed for Volume Emphasis (or any other shape mapped sound design).

For Build Up, I'd like to discuss the following at design meeting today: 1) Reducing the Convex quad track to make it less interesting, but retain some nice foundational, constant quality the beat provides. Consider how it can mirror the Concave sound (either by adjusting concave or convex). 2) Consider the tracks use for 1 and 2 parallel pairs (trapezoid and parallelogram respectively). It'd be nice if they had some quality that built up going from 1 to 2, but ideally they should be distinct enough on their own.

brettfiedler commented 2 years ago

@Ashton-Morris , go ahead with coming up with ideas/tracks for item 2 above

Consider the tracks use for 1 and 2 parallel pairs (trapezoid and parallelogram respectively). It'd be nice if they had some quality that built up going from 1 to 2, but ideally they should be distinct enough on their own.

And I'll add in a specific item for item 1 soon.

Ashton-Morris commented 2 years ago

I uploaded some new audio files for the above conversation.

  1. "Reducing the Convex quad track to make it less interesting, but retain some nice foundational, constant quality the beat provides. Consider how it can mirror the Concave sound (either by adjusting concave or convex)."
    • I have added Quad_Base_Beat_Simpler.wav and Quad_Base_Beat_Simpler.mp3 to try for this
    • I also have two options to try instead of "Quad_Simple_Building_Tracks-000.wav"

Quad_Base_Beat_Simpler_Concave_Quadrilateral_Just_Rhythm.wav Quad_Base_Beat_Simpler_Concave_Quadrilateral_Just_Rhythm.mp3 Quad_Base_Beat_Simpler_Concave_Quadrilateral.wav Quad_Base_Beat_Simpler_Concave_Quadrilateral.mp3

  1. "Consider the tracks use for 1 and 2 parallel pairs (trapezoid and parallelogram respectively). It'd be nice if they had some quality that built up going from 1 to 2, but ideally they should be distinct enough on their own." For this I have Quad_Simple_Building_Tracks-004-Trapezoid.wav and Quad_Simple_Building_Tracks-004-Trapezoid.mp3 to try in place of "Quad_Simple_Building_Tracks-004"
Ashton-Morris commented 2 years ago

@jessegreenberg It should be just replacing existing files but let me know if you have any questions regardless.

jessegreenberg commented 2 years ago

This was discussed in meeting today, @Ashton-Morris demoed the new sounds and everyone thought they were great! They accomplished the pedagogical needs described above.

@Ashton-Morris is going to adjust or add a couple of sounds and @BLFiedler is going to identify how they should be mapped into the tracks designs.

Ashton-Morris commented 2 years ago

Adding two more files.

brettfiedler commented 2 years ago

A few changes to test out for the Build Up Simple sound design and a general mixing change:

Default Sound Design

Default Volume for Shape Music

We would like to lower the volume of the shape music overall. Ashton indicated that the Reset All is the “baseline volume” is at 0.7 and suggested:

Reset will be just slightly more prominent.

Reassign tracks for 1. Tracks - Build Up - Simple.

We have a lot of tracks now! I spent a bit of time reassigning tracks to the different mapping for Tracks - Build Up - Simple. The mappings for each shape are the same. Just the tracks are being swapped.

All tracks are found in this Drive folder. I moved a few older files into an Archive Subdirectory, but all of the below files are in the main directory.

A. (base) Quad_Base_Beat_Simpler (0) B. (inversion) Quad_Base_Beat_Simpler_Concave_Quadrilateral_Just_Rhythm_v2 (1) C. (diag symmetry) Quad_Beat_Tracks_Building_Building_Tracks-000 (2) D. (lat symmetry) Quad__Simple_Building_Tracks-007 (3) E. (1 x parallel) Quad_Simple_Building_Tracks-004-Trapezoid (4) F. (2 x parallel) Quad_Beat_Tracks_Building_Building_Tracks-004 (5) G. (sides equal) Quad_Melody_Tracks-004 (6) H. (angles equal) Quad_Beat_Tracks_Building_Building_Tracks-005 (7)

Overall look at what sounds play with which shape (unchanged)

JG EDIT: Here is the link to the folder, above was just a link to the track - https://drive.google.com/drive/folders/1YNrthgUqZXTQw-gA8ch6XIwBZ_RhsIKW

JG EDIT: Tracks are referenced by index in code so I added numbers so it is easier to check implementation against design. And that ended up confirming that none of the assigned values changed only the tracks :)

jessegreenberg commented 2 years ago

Alright, sounds good @BLFiedler! (finger guns)

I believe this is in place as you described, back to you.

brettfiedler commented 2 years ago

I'm seeing the change in default sound design and adjustment in volume, but not the correct mappings. Messaged JG with the following:

I think there is some scrambling in the audio files. [...]. I quickly copied over the relevant files in the Audio folder to a new folder for this iteration and renamed the files to have the index up front: https://drive.google.com/drive/folders/1JSN2Obe1OpOaY2qJKFsh31IVnLchUZlz?usp=sharing

Updated mapping:

index filename category
0 0-Quad_Base_Beat_Simpler convex/base
1 1-Quad_Base_Beat_Simpler_Concave_Quadrilateral_Just_Rhythm_v2 concave/inverted
2 2-Quad_Beat_Tracks_Building_Building_Tracks-000 diagonal symmetry
3 3-Quad__Simple_Building_Tracks-007 lateral symmetry
4 4-Quad_Simple_Building_Tracks-004-Trapezoid 1x Parallel Sides
5 5-Quad_Beat_Tracks_Building_Building_Tracks-004 2x Parallel Sides
6 6-Quad_Melody_Tracks-004 Equal Sides
7 7-Quad_Beat_Tracks_Building_Building_Tracks-005 Equal Angles
jessegreenberg commented 2 years ago

I just pushed to quadrilateral for another issue and now see https://github.com/phetsims/quadrilateral/commit/347aae22c51247fcf11f2782f0d045c3afd1d667 came through just today which is the commit that rearranged the sound files...so that explains why the mappings were not right. Sorry about that!

Back to @BLFiedler to try now that https://github.com/phetsims/quadrilateral/commit/347aae22c51247fcf11f2782f0d045c3afd1d667 is pushed to remote.

brettfiedler commented 2 years ago

Wooo. Well, I think that's worth some listening for folks.

Could we post a dev version? If possible before the meeting tomorrow, but no worries if not.

My personal thoughts (given my own assignments :) )

jessegreenberg commented 2 years ago

Sure, here is a dev version with https://github.com/phetsims/quadrilateral/commit/347aae22c51247fcf11f2782f0d045c3afd1d667!

https://phet-dev.colorado.edu/html/quadrilateral/1.0.0-dev.66/phet/quadrilateral_en_phet.html

brettfiedler commented 2 years ago

In chatting with Taliesin, we concluded the following track swap might address some concerns while playing with a trapezoid:

index filename category
0 0-Quad_Base_Beat_Simpler convex/base
1 1-Quad_Base_Beat_Simpler_Concave_Quadrilateral_Just_Rhythm_v2 concave/inverted
2 2-Quad_Beat_Tracks_Building_Building_Tracks-000 diagonal symmetry
3 3-Quad__Simple_Building_Tracks-007 lateral symmetry
4 >>4-Quad_Beat_Tracks_Building_Building_Tracks-003 << 1x Parallel Sides
5 5-Quad_Beat_Tracks_Building_Building_Tracks-004 2x Parallel Sides
6 6-Quad_Melody_Tracks-004 Equal Sides
7 7-Quad_Beat_Tracks_Building_Building_Tracks-005 Equal Angles
brettfiedler commented 2 years ago

Assign back when swap has happened and we'll work on volume mixing of tracks for individual shapes. e.g., Equal Sides (index 6) is a bit loud in the Rhombus and Square.

jessegreenberg commented 2 years ago

Swap was made in https://github.com/phetsims/quadrilateral/commit/060eded29d3ac09fcb252570cf7aba558ed9d039, back to @BLFiedler.

jessegreenberg commented 2 years ago

We reviewed this today and decided that the output levels of individual tracks in each design needs to be adjusted. It would be quick to add some temporary controls to adjust the output levels so Ill do that in case it helps with the sound design.

jessegreenberg commented 2 years ago

@BLFiedler @Ashton-Morris I added some controls for this under the ?soundBoard query parameter. You can control the output of sound levels for individual tracks with this

![image](https://user-images.githubusercontent.com/6396244/196727659-b9055731-d6b4-447f-af3b-78c534281a56.png)

Please note that ONLY the sounds assigned to each shape are controllable. So when a sound is not playing for a particular shape, the related slider has no impact on the output. It also isn't possible to control the "ambient" output in the "Shape Emphasis" design. If it would be helpful to have full control over these things let me know - it would be a simple change but I thought that would actually add confusion at this point to change the designs that much.

brettfiedler commented 1 year ago

Placeholder for now - I think I like this configuration. Note, I also lowered MAX_OUTPUT_LEVEL = 0.3

Image

brettfiedler commented 1 year ago

Let's commit to this change ahead of anyone else using the sim.

@jessegreenberg

jessegreenberg commented 1 year ago

Adjust track volumes according to graphic in previous post.

@BLFiedler are those the values I should use for both sound designs?

brettfiedler commented 1 year ago

These apply only to Build up, though the overall output level should decrease for both sound designs.

A change to a couple of tracks are needed for Shape/Volume Emphasis. Keeping myself assigned for that task.

jessegreenberg commented 1 year ago

https://github.com/phetsims/quadrilateral/issues/175#issuecomment-1351752296 done, and set up so that the other sound design can have its own set of output level values when ready. Back to @BLFiedler for next steps.

brettfiedler commented 1 year ago

For the secondary sound design, I swapped a few tracks for ones not being used that were a little less punchy, and differentiated Concave and Convex a bit more (moved concave to the simpler concave beat) in the above commit. I also restored the background volume to 0.15.

I wanted to make a few volume adjustment requests and then call this complete.

@jessegreenberg, I have a few mixing requests for when the sounds are foregrounded, but also one for the background.

jessegreenberg commented 1 year ago

Done. @BLFiedler can you please review?

brettfiedler commented 1 year ago

Regardless of where it was, it sounds good to me now.

  • Can you make individual adjustments to the following tracks when they are foregrounded:

  • 2.) The rectangle sound (track index 5), dominates a lot of the background tracks.

Ack. I requested the wrong track. Meant 6 instead of 5. But, since you put in the structure @jessegreenberg, I could easily fix my mistake :) Done in above commit. I also raised the background volume of the trapezoid track.

I'm calling this design complete :dusts hands:

Offering to @Ashton-Morris to do a full review of the shape sounds in both designs (can be changed in the Preferences menu) before closing this issue.