search

phetsims / quadrilateral

"Quadrilateral" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

Delete tiltProperty? #384

Closed jessegreenberg closed 1 year ago

jessegreenberg commented 1 year ago

"Tilt" used to be an important concept in this sim, but it is not anymore and we might be able to remove this Property. Everything is now based on geometric properties like vertex angle, pairs of parallel sides, and others.

If we can, we can also delete calculateAngle in Vertex.ts which is only used to calculate the tilt for some reason.

jessegreenberg commented 1 year ago

I don't see any usages of side.tiltProperty, nor of the saved values in ShapeSnapshot. I am going to delete this.

jessegreenberg commented 1 year ago

All options passed to Side were related to tiltProperty so they can be removed too.

jessegreenberg commented 1 year ago

Also, these two in the QuadrilateralDescriber are not used

    // TODO: Do we need a query parameter for this?
    // TODO: CAn tilt be removed?
    this.tiltDifferenceToleranceInterval = 0.2;
    this.lengthDifferenceToleranceInterval = 0.05;
jessegreenberg commented 1 year ago

Nice, this cleaned up a lot of things. Changes in wip-2-22-23. Closing.