search

phetsims / quadrilateral

"Quadrilateral" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 3 forks source link

Add unit tests #404

Closed samreid closed 1 year ago

samreid commented 1 year ago

From https://github.com/phetsims/quadrilateral/issues/403, we would like to add unit tests for the QuadrilateralShapeDetection in particular.

jessegreenberg commented 1 year ago

I added unit tests for shape detection, and it has been nice to have them while making changes for #398. While not exhaustive it covers one of each shape and the sim is now set up to add more unit tests if we want.

@samreid @matthew-blackman would you like to see anything else here or any other tests?

samreid commented 1 year ago

I read the commits, tested running the unit tests, and I tried disrupting one of the tests to make sure it correctly failed. Everything seems good, nice work, closing.