Closed zepumph closed 5 years ago
Sounds excellent, good idea! Reassign me if you want help getting it set up.
@chrisklus do you think this would be something that you would be interested in doing? Documentation is sometimes difficult while still getting your bearings, but it can also be a nice way to learn about this module of the codebase. @samreid please let me know if you think there could be a better way to do this.
There is already some high-level documentation at https://github.com/phetsims/query-string-machine/
@zepumph were you picturing adding some smaller more isolated examples like the ones in our wrapper suite?
In general it just is out of date, and incomplete. This is the first sentence:
Query String parser that supports type coercion, defaults, error checking, etc. based on a schema. Runs in browser or node. Small and only depends on window.assert and _.isEqual.
It does not depend on either of those.
I was picturing:
TYPES
var into a human readable layout, or at least pointing people to that place in code for that doc (not sure what's best).get
rather than getAll
would be nice.@memberof
annotations.Does that align with what you were thinking @samreid @chrisklus?
That sounds great to me!
Let me know if you have any more questions @chrisklus.
I'm going to work on this for a bit, reassigning and notifying on slack just in case.
@chrisklus and I worked on this today. @zepumph can you please take a look?
This is awesome. Well done folks. Thank you.
We are going to be exposing QueryStringMachine to PhET-iO clients to use if they see fit. In the phet-io documentation I think it would be best to just point them to the readme for QueryStringMachine on github, rather than to create another, parallel documentation strategy. Tagging @samreid for comment.
EDIT: missed word