phetsims / query-string-machine

Query String Machine is a query string parser that supports type coercion, default values & validation. No dependencies.
MIT License
3 stars 3 forks source link

Update readme #32

Closed zepumph closed 5 years ago

zepumph commented 6 years ago

We are going to be exposing QueryStringMachine to PhET-iO clients to use if they see fit. In the phet-io documentation I think it would be best to just point them to the readme for QueryStringMachine on github, rather than to create another, parallel documentation strategy. Tagging @samreid for comment.

EDIT: missed word

zepumph commented 6 years ago

From https://github.com/phetsims/phet-io-wrappers/issues/74

samreid commented 6 years ago

Sounds excellent, good idea! Reassign me if you want help getting it set up.

zepumph commented 6 years ago

@chrisklus do you think this would be something that you would be interested in doing? Documentation is sometimes difficult while still getting your bearings, but it can also be a nice way to learn about this module of the codebase. @samreid please let me know if you think there could be a better way to do this.

samreid commented 6 years ago

There is already some high-level documentation at https://github.com/phetsims/query-string-machine/

@zepumph were you picturing adding some smaller more isolated examples like the ones in our wrapper suite?

zepumph commented 6 years ago

In general it just is out of date, and incomplete. This is the first sentence:

Query String parser that supports type coercion, defaults, error checking, etc. based on a schema. Runs in browser or node. Small and only depends on window.assert and _.isEqual.

It does not depend on either of those.

I was picturing:

Does that align with what you were thinking @samreid @chrisklus?

samreid commented 6 years ago

That sounds great to me!

zepumph commented 6 years ago

Let me know if you have any more questions @chrisklus.

samreid commented 6 years ago

I'm going to work on this for a bit, reassigning and notifying on slack just in case.

samreid commented 6 years ago

@chrisklus and I worked on this today. @zepumph can you please take a look?

zepumph commented 5 years ago

This is awesome. Well done folks. Thank you.