Camera Input causing browser crash

phetsims / ratio-and-proportion

"Ratio and Proportion" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

1 stars 4 forks source link

Camera Input causing browser crash #510

Closed zepumph closed 1 year ago

zepumph commented 2 years ago

Over in https://github.com/phetsims/ratio-and-proportion/issues/501#issuecomment-1240899536 @Nancy-Salpepi reported a memory leak that crashed the browser after 30 minutes:

With Win10 + FF, I left the sim open for 30 minutes with the camera input: hands and voicing activated. When I returned, there was a message that FF crashed.

zepumph commented 2 years ago

I'm not too sure about this. I had the sim running for 30 minutes and took a memory snapshot after and before, and they were only 1MB different. I will test again, this time on firefox, and see if I can get anything to reproduce. It doesn't immediately strike me as a memory leak anymore.

stemilymill commented 2 years ago

I reproduced this also on win10 firefox, but in less than 20 minutes this time. please let me know if there is any additional info that may help

zepumph commented 2 years ago

I had this link open all afternoon yesterday, and even this morning it hadn't yet crashed my browser, I'll keep testing.

http://localhost:8080/ratio-and-proportion/ratio-and-proportion_en.html?brand=phet&ea&debugger&voicingInitiallyEnabled&printVoicingResponses&preferencesStorage&cameraInput=hands

zepumph commented 2 years ago

Maybe it is the built version only!?!

zepumph commented 1 year ago

I don't think this is a memory leak:

zepumph commented 1 year ago

@emily-phet and I feel like this is not worth fixing for this release, given that I have not yet been able to reproduce this. Closing