search

phetsims / ratio-and-proportion

"Ratio and Proportion" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 4 forks source link

Some strings are no longer translated #515

Closed KatieWoe closed 1 year ago

KatieWoe commented 2 years ago

Test device Dell Operating System Win 11 Browser Chrome Problem description For https://github.com/phetsims/qa/issues/831. The "Challenge 1," "Challenge 2," "Challenge 3," and "Ratio Lock" strings are no longer translated in any language, even though they may be in the published sim.

Visuals

Nottranslate2 nottranslate1

Troubleshooting information:

!!!!! DO NOT EDIT !!!!! Name: ‪Ratio and Proportion‬ URL: https://phet-dev.colorado.edu/html/ratio-and-proportion/1.2.0-dev.31/phet/ratio-and-proportion_all_phet.html Version: 1.2.0-dev.31 2022-08-24 16:50:40 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/105.0.0.0 Safari/537.36 Language: en-US Window: 1280x649 Pixel Ratio: 1.5/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {}
zepumph commented 1 year ago

This is fixed by https://github.com/phetsims/ratio-and-proportion/issues/499

KatieWoe commented 1 year ago

Testing for https://github.com/phetsims/ratio-and-proportion/issues/499. While the Challenge strings are now translated, the Ratio Lock string still isn't. Reopening.

zepumph commented 1 year ago

Thanks. I renamed the string key and thought it wouldn't matter. My bad! I brought it back. Thanks for reopening. I appreciate it and apologize that you had to pick up my slack. Closing