search

phetsims / ratio-and-proportion

"Ratio and Proportion" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 4 forks source link

Voicing compares hand location to same hand #526

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 2 years ago

Test device MacBook Air (m1 chip)

Operating System macOS 13.0.1

Browser safari 16.1 and chrome

Problem description For https://github.com/phetsims/qa/issues/852, when moving the left hand, voicing compares its location to 'left hand' and the same thing happens when moving the right hand.

Steps to reproduce

  1. Turn on Voicing and check Sim Voicing Options checkboxes
  2. On either screen, move left hand --new position compared to left hand
  3. Move right hand--new position compared to right hand

Visuals

https://user-images.githubusercontent.com/87318828/202239157-6ec40515-709b-4acf-8759-00937b698313.mov

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Ratio and Proportion‬ URL: https://phet-dev.colorado.edu/html/ratio-and-proportion/1.2.0-rc.1/phet/ratio-and-proportion_all_phet.html Version: 1.2.0-rc.1 2022-11-11 22:40:36 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36 Language: en-US Window: 1544x712 Pixel Ratio: 1.7999999523162842/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
Nancy-Salpepi commented 1 year ago

I also see this issue with VoiceOver and in a11y view

zepumph commented 1 year ago

Well that is less than ideal!!

Looks like the bug is not in https://phet-dev.colorado.edu/html/ratio-and-proportion/1.2.0-dev.31/phet/ratio-and-proportion_all_phet.html?printVoicingResponses&voicingInitiallyEnabled&preferencesStorage, and is in https://phet-dev.colorado.edu/html/ratio-and-proportion/1.2.0-dev.32/phet/ratio-and-proportion_all_phet.html?printVoicingResponses&voicingInitiallyEnabled&preferencesStorage. I'll take a look.

zepumph commented 1 year ago

94f074fdab69ebcf6c3230da52affc45093704de has the bug, 5ee9dc4425851249078de3d8fb709f3401771deb does not.

zepumph commented 1 year ago

Classic, looks like the bug was introduced by a simple mistake in https://github.com/phetsims/ratio-and-proportion/commit/d4f186a42f9bc72f3cca525ea61891dc62334678#diff-b1e62322eee34f09e99fbdae2de1b90ed22ebae29b875e92c7bf5567705483a2L284.

zepumph commented 1 year ago

Fixed by https://github.com/phetsims/ratio-and-proportion/commit/91fa9af5166f36d970bd8e7c18e3cfaefb20f2bd, to cherry pick that.

zepumph commented 1 year ago

Done and ready for confirmation in next version.

Nancy-Salpepi commented 1 year ago

This looks good in 1.2.0-rc.2 with Voicing, VoiceOver and a11y view on mac + safari. Will reopen if anything comes up.