phetsims / ratio-and-proportion

"Ratio and Proportion" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 4 forks source link

Camera Input doesn't work with LoL #531

Closed KatieWoe closed 1 year ago

KatieWoe commented 1 year ago

Test device Samsung Operating System Win 11 Browser Chrome Problem description For https://github.com/phetsims/qa/issues/852 When running the sim in Legends of Learning, if you enable the camera input a warning pops up saying no camera is available. Steps to reproduce

  1. Enter the sim in the LoL harness with the cameraInput=hands parameter.

Visuals lolhands

Troubleshooting information:

!!!!! DO NOT EDIT !!!!! Name: ‪Ratio and Proportion‬ URL: https://phet-dev.colorado.edu/html/ratio-and-proportion/1.2.0-rc.1/phet/ratio-and-proportion_all_phet.html Version: 1.2.0-rc.1 2022-11-11 22:40:36 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36 Language: en-US Window: 1536x714 Pixel Ratio: 1.25/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {}
emily-phet commented 1 year ago

I don't think we need to support the camera input / lol combo.

brettfiedler commented 1 year ago

Is this generally true for the sim in any iframe or unique to LoL?

KatieWoe commented 1 year ago

The hands worked in the iframe, but not in LoL

zepumph commented 1 year ago

I'm happy to not support this, but I'd like to know what's going on. That message is most often because you have another tab opened that is using you webcam. What's a link that I can reproduce this? Feel free to message me instead if you don't want that on github.

zepumph commented 1 year ago

Also, I noticed the URL is in the "Troubleshooting details", but without the query string. Do you purposefully remove those, or is there a bug somewhere? It may be nice to include those in the issue unless there is a reason not to. Let me know if you want to talk to try to reproduce.

KatieWoe commented 1 year ago

I didn't purposely remove it. I'm not sure why it isn't there.

zepumph commented 1 year ago

@emily-phet and I don't think we should look into this any further. Closing